Skip to content
This repository has been archived by the owner. It is now read-only.

Test performance of Firefox with Page Shot on Talos #2317

Closed
ianb opened this issue Mar 8, 2017 · 5 comments
Closed

Test performance of Firefox with Page Shot on Talos #2317

ianb opened this issue Mar 8, 2017 · 5 comments
Assignees

Comments

@ianb
Copy link
Contributor

@ianb ianb commented Mar 8, 2017

There's a possibility that simply having Page Shot installed will affect the performance of Firefox. As soon as #2313 lands we should see if this is the case using Talos.

@ianb ianb added the releng label Mar 8, 2017
@ianb ianb modified the milestone: Page Shot in 54 Mar 8, 2017
@Standard8 Standard8 self-assigned this Mar 27, 2017
@Standard8
Copy link
Contributor

@Standard8 Standard8 commented Mar 27, 2017

I discovered today that this is how you do it:

  • Push a patch to try with Talos runs
  • Either compare it against central, or another try push, via

https://treeherder.mozilla.org/perf.html#/comparechooser

I'll update the build patches, then get these pushed.

@Standard8
Copy link
Contributor

@Standard8 Standard8 commented Mar 28, 2017

From what I can tell, the Talos run doesn't show anything we need to worry about, but I've sent an email to jmaher to get extra confidence.

@jaredhirsch
Copy link
Member

@jaredhirsch jaredhirsch commented Mar 29, 2017

For reference, here's the (Mozilla staff-only) link to the Talos conversation on the screenshots-staff list: https://groups.google.com/a/mozilla.com/d/topic/screenshots-staff/MBCS3GkepII/discussion

@Standard8
Copy link
Contributor

@Standard8 Standard8 commented Mar 30, 2017

Everything looks good - the Win64 tests showed OK as well. So I think we can close this now.

@Standard8 Standard8 closed this Mar 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants