Skip to content
This repository has been archived by the owner. It is now read-only.

Page Shot button no longer redirects you to the "My Shots" page if it's clicked from Activity Stream New Tab #2429

Closed
SoftVision-CosminMuntean opened this issue Mar 20, 2017 · 3 comments

Comments

@SoftVision-CosminMuntean

[Notes]:

  • This issue is also reproducible for Cliqz New Tab.

[Affected versions]:

  • Nightly 55.0a1 (Build ID: 20170320030209)
  • Page Shot 5.2.7704

[Affected Platforms]:

  • All Windows
  • All Mac
  • All Linux

[Prerequisites]:

  • The "xpinstall.signatures.required" is set to "false" and latest Page Shot (5.2.7704) custom build is installed on a new clean profile.
  • Activity Stream add-on was previously installed on the created profile.

[Steps to reproduce]:

  1. Open Firefox with the profile from prerequisites and open a new tab.
  2. Click on the "Page Shot" button from the main toolbar.
  3. Observe the browser behavior.

[Expected result]:

  • You are redirected to the "My Shots" page.

[Actual result]:

  • A "No window matching" error is displayed and you are not redirected to the "My Shots" page.

[Additional Notes:]

  • With Page Shot Test Pilot version, after clicking the "Page Shot" button you are redirected to "My Shots" page.
  • Here is a screen recording with the issue:
    activity stream new tab vs page shot
@wresuolc wresuolc added this to the Screenshots in 54 milestone Mar 20, 2017
@wresuolc
Copy link
Contributor

@wresuolc wresuolc commented Mar 20, 2017

@dannycoates has a PR that might fix this

@ianb
Copy link
Contributor

@ianb ianb commented Mar 22, 2017

See the function shouldOpenMyShots() for where you'd change this.

@dannycoates
Copy link
Contributor

@dannycoates dannycoates commented Mar 22, 2017

ought to be fix in #2368

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants