[l10n] Localizability issues with introduction steps

[flodolo]

Not sure how done this is, but better filing for nothing than forgetting.

Using text-transform: uppercase is a bad idea in general.

Again, text-transform, and unlocalized string. Also, fixed width is really risky, see how crowded Italian is, and it's not even the wordiest language.

Hard-coded skip and done, but more important, that "DONE" solution is going to work for maybe 5 or 6 locales, you need something that stretches to fit way longer text.

[ghost]

@johngruen assigning this to you in our triage. If that's not right, let us know.

[johngruen]

@flodolo thanks for this review... I think my PR fixes some of this stuff, and others we can work around. @pdehaan any brilliant way to grep for string length so we can figure out locales with the longest strings?

[pdehaan]

@johngruen We could maybe do some grep for string length (or character count), but not sure how reliable it'd be (since five "i"s will be much smaller than 4 "w"s, for example).
We could maybe just render each of those strings into a DOM element and then measure it's rendered width... meh.

[ianb]

In 2dc1dd4 I changed SKIP to be the text SKIP and removed the text-transform, so that localizers can apply their own judgement. That commit also replaces DONE entirely, replacing it with a checkmark icon.

@johngruen changed "Firefox Screenshots BETA" to be a fixed string that does not get translated at all.

I think there's still the possibility of explanatory or header text overflowing the containers, as almost happens in your second screenshot.

[johngruen]

Hey @flodolo mind taking a look, we've made some changes that i think address most of your issues

[flodolo]

Is there an easy way to trigger this without creating a new profile?

Remaining issue: text-transform on "Skip".

I'm still seeing the text, not a checkmark

Note that the layout is still risky. Italian fits, I'm not sure all languages will

[SoftVision-CosminMuntean]

Is there an easy way to trigger this without creating a new profile?

@flodolo If you remove the add-on from "about:addons" page, then if you reinstall it, should work.

[flodolo]

@flodolo If you remove the add-on from "about:addons" page, then if you reinstall it, should work.

Thanks, it works. I was expecting this to be stored behind a pref, but it isn't.

For completeness, I'm on 6.0.9943 and still seeing DONE instead of a checkmark.

[jaredhirsch]

Remaining issue: text-transform on "Skip".

It looks like the string is actually uppercased in the properties file. Maybe we should add a note for localizers?

For completeness, I'm on 6.0.9943 and still seeing DONE instead of a checkmark.

Seems fixed on current master to me:

[flodolo]

It looks like the string is actually uppercased in the properties file. Maybe we should add a note for localizers?

Sorry, I was looking at "Done" and didn't think to check SKIP. If it's uppercase in the file, that's OK, locales can decide to keep it or use lowercase.

Seems fixed on current master to me:

Definitely not on https://pageshot.dev.mozaws.net/homepage/install-test-local.html (also don't have images), which brings to the next question: how often is that add-on updated?

[ghost]

@ianb is going to update the -dev add-on. right now it's a manual process

[ianb]

We're planning on automating the dev deployment before we go live on server localization. I believe all other issues have been fixed – no text-transform, and we use an icon for "done".