Skip to content
This repository has been archived by the owner. It is now read-only.

"This Element is null" error is constantly thrown if pressing the escape button while resizing the browser #2994

Closed
emilghittasv opened this issue Jun 8, 2017 · 2 comments
Assignees
Milestone

Comments

@emilghittasv
Copy link
Collaborator

@emilghittasv emilghittasv commented Jun 8, 2017

[Affected versions]:
Firefox 55.0a1 (Build Id:20170608030205)
Firefox Screenshots 9.0.0

[Affected platforms]:
Windows 10 64 bit
Ubuntu 16.04 64bit

[Steps to reproduce]:

1.Open Firefox with a clean profile.
2.Click on the Screenshots button.
3.Dismiss the tutorial.
4.Press the escape button while resizing the browser.

[Expected result]:
Screenshots is successfully closed.

[Actual result]:
An error is thrown with a type error : "This.element is null".

[Additional notes]
Please observe the following video for more information: https://drive.google.com/open?id=0B94iuIVMr-TEREZkSjh6czVDRGM

@ianb
Copy link
Contributor

@ianb ianb commented Jun 8, 2017

I believe this Sentry report is from this error.

@wresuolc wresuolc added this to the Stretch milestone Jun 8, 2017
@ianb ianb self-assigned this Jun 9, 2017
@ianb
Copy link
Contributor

@ianb ianb commented Jun 9, 2017

I wasn't able to reproduce this, but given the Sentry report and the steps I'm pretty sure I understand and can fix the error.

ianb added a commit that referenced this issue Jun 9, 2017
There is a timer attached to updateElementSize, so that it can run after the selector is unloaded, leading to an unnecessary error
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants