Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Update homepage to reflect 57 #3444

Closed
johngruen opened this issue Aug 31, 2017 · 2 comments
Closed

Update homepage to reflect 57 #3444

johngruen opened this issue Aug 31, 2017 · 2 comments
Assignees
@jaredhirsch
Labels
P1
Milestone
General Release 57

Comments

@johngruen
Copy link
Contributor

Currently the screenshots homepage reflects pre-photon UI for both firefox and Screenshots.

We need to do the following:

  1. If the user is on <= 56 or in a non-ff browser, the UI should remain the same.
  2. If the user is on 57 +, we should reveal the currently hidden Full page capture section
  3. If the user is on 57 + we should swap the Get Started section as follows:

Once 57 formally ships in release, we should change the show/hide logic for here so that non-FF users and 57 users see the same thing.
@johngruen johngruen added the P1 label Aug 31, 2017
@johngruen johngruen added this to the General Release 57 milestone Aug 31, 2017
@scheinercc
Copy link

Was looking for the screenshots icon (using it since it was in test pilot) and couldn't find it anymore, also not as add-on. When checking the about:newtab on-boarding I landed the screenshots homepage stating the icon should be there. I already checked bugzilla for reports of missing screenshots add-on.
Eventually found this bug ... and the tool ;)

@jaredhirsch jaredhirsch self-assigned this Sep 6, 2017
@truboxl
Copy link

truboxl commented Sep 7, 2017 •
edited

I thought something is wrong, everytime I do a new profile cleanup, it doesn't show up in the Customize section. Then it takes me quite some time to find this bug report, so that's where the Screenshot button now at, oh well...

jaredhirsch added a commit that referenced this issue Sep 7, 2017
@jaredhirsch
Fix #3444, toggle different onboarding tour for FF 57+
90a4ca8
jaredhirsch added a commit that referenced this issue Sep 7, 2017
@jaredhirsch
Fix #3444, toggle different onboarding tour for FF 57+
f7dc230
jaredhirsch added a commit that referenced this issue Sep 8, 2017
@jaredhirsch
Fix #3444, toggle different onboarding tour for FF 57+
67a3262 
- For 57+, include the full screen / save visible step in the tour, for
  four steps overall. Also change the Get Started text and image to
  refer to a page action, not a toolbar button.

- For 56- and non-FF browsers, show the three step tour and refer to the
  toolbar button.

- Add some trivial model unit tests, to get that ball rolling.
@jaredhirsch jaredhirsch mentioned this issue Sep 8, 2017
Merged
@ianb ianb closed this as completed in d07db41 Sep 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jaredhirsch jaredhirsch

Labels
P1
Projects
None yet
Milestone
General Release 57
Development

No branches or pull requests
4 participants
@jaredhirsch @scheinercc @johngruen @truboxl