New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metabug] Make Screenshots a regular, non-embedded webextension #3875

Closed
6a68 opened this Issue Dec 2, 2017 · 1 comment

Comments

Projects
None yet
4 participants
@6a68
Member

6a68 commented Dec 2, 2017

last updated 12 Sep 2018

Metabug to track work needed to remove the bootstrapped wrapper from Screenshots:

Open items:

Lifecycle

  • Check the disabled pref inside the webextension before loading the UI code (#4811)
    • The addons team did this for us, moving the disabled pref check into the browser (bug 1488971)
  • Init the Library menu item from the webextension (#4812)
    • For now, the Library item is initialized via the embedded API. This will eventually be removed when the addons team allows webextensions to register Library items (bug 1483609)

Preferences handling

  • short-term:
    • Use an API experiment to access about:config prefs (#4800)
    • Make sure we need the history.enabled check and, if so, check it from the webextension (#4531)
  • longer term:
    • Replace prefs with storage.managed equivalents? (#4773)
    • Expose disable and disable-upload options in the about:preferences page? (#2711)

Uploads and ESR

  • short-term:
    • Use an API experiment to check the update channel (#4802)
  • longer term:
    • Check if platform is ESR from WebExtension (#4772)
    • Add server version (necessary if ESR is allowed to upload; first step to ensuring older ESR clients can indicate they are submitting an older version of the upload packet) (#4775)
      • Note that, right now, we are sticking with the original policy of not allowing ESR to upload at all

Build related:

  • Remove jpm and bootstrap references from Makefile / build tools
    • Ran into a weird error with jpm removal, leaving it in there for now (#4873)

Completed items:

The BMO dependencies are also tracked in the BMO bug: https://bugzil.la/1422437

@6a68

This comment has been minimized.

Member

6a68 commented Sep 12, 2018

🎉

Landed the webextension PR in #4864. Individual follow-up bugs have been filed for all the stuff marked 'longer-term' in the description. Closing ^_^

@6a68 6a68 closed this Sep 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment