Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Screenshot crop is misaligned on specific page #4018

Closed
ianb opened this issue Jan 25, 2018 · 5 comments
Closed

Screenshot crop is misaligned on specific page #4018

ianb opened this issue Jan 25, 2018 · 5 comments

Comments

@ianb
Copy link
Contributor

ianb commented Jan 25, 2018

Copied from Bug 1432755

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:58.0) Gecko/20100101 Firefox/58.0
Build ID: 20180118215408

Steps to reproduce:

  • Deploy the page attached on a local server (apache, or other, does not matter) (it fails with other pages on localhost too, but not directory listings, so I provided a page with which it occurs)
  • Open the screenshots tool in the awesome bar
  • With the mouse (not the "Capture the whole page button), try to capture from the left of the window to the right

Actual results:

You can't reach the right side.
If you submit the screenshot like this, it appears like the whole crop zone was translated on the horizontal axis.

Look at this screenshot (made with another tool): https://framapic.org/2fkK8KYJvtgA/EdyujaPoB7tH.png

The black zone does not reach the right side.

Expected results:

I should be able to capture the whole width.

@nicofrand
Copy link

nicofrand commented Jan 25, 2018

I tried reducing it to a small case but it seems to appear only on localhost (I do not host the same page online but I tested on several local pages and met the issue whereas I never had the issue with any online webpage) and even when removing most of the DOM nodes the issue persisted.

@SoftVision-CosminMuntean

I have managed to reproduce this issue using the provided page on latest Firefox 58.0 release on Windows 7 x64. But, the issue is not reproducible on latest Nightly 60.0a1 build.

I think that this issue is similar with #3907 which was fixed in the latest Screenshots versions.
@nicofrand can you retest this on latest Nightly 60.0a1 build and confirm that the issue is fixed?

@nicofrand
Copy link

Hi !

It does seem to be a duplicate indeed. However the nightly did not fix the issue of npr.org:

bug-firefox

It did not fix it with my page neither:

bug-firefox

PS : feel free to reopen the other issue and close this one (and copy my comment/screenshot maybe)

@SoftVision-CosminMuntean

@nicofrand I'm sorry for sending you on a wild goose chase! It seems that the fix didn't land in Nightly yet and I didn't notice that I had tested this scenario using Screenshots 28.0.0 dev version. However, the issue is fixed and will land in the next release.
You can also check this by installing the Screenshots dev version from here.

@nicofrand
Copy link

That's ok, glad it's fixed ! Well done to everyone involved.

I confirm this is fixed for both npr.org and my case, you can close this issue, thanks !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants