Skip to content
This repository has been archived by the owner. It is now read-only.

/ screenshots Archived

Chrome prototype: security issues #4302

Closed
jaredhirsch opened this issue Apr 3, 2018 · 1 comment
Closed

Chrome prototype: security issues #4302

jaredhirsch opened this issue Apr 3, 2018 · 1 comment
Milestone
Chrome Launch 🎈

Comments

@jaredhirsch
Copy link
Member

@jaredhirsch jaredhirsch commented Apr 3, 2018

For the Chrome prototype to work, I've inserted a few hacks:

  • csrf disabled on the server side
  • iframe src set to that of the page, not that of the extension

These should be resolved before shipping.
@wresuolc wresuolc added this to the Sprint 10 (61-2) ⛅ milestone Apr 5, 2018
@jaredhirsch jaredhirsch added the P1 label Apr 17, 2018
@jaredhirsch jaredhirsch self-assigned this Apr 17, 2018
@wresuolc wresuolc removed the P1 label May 14, 2018
@jaredhirsch jaredhirsch removed their assignment Jan 3, 2019
@ianb
Copy link
Contributor

@ianb ianb commented Feb 7, 2019

I don't think we're going to launch on Chrome
@ianb ianb closed this Feb 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Chrome Launch 🎈
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
7 participants
@ianb @clouserw @jaredhirsch @chenba @johngruen @wresuolc @marniepw