Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Set a default NODE_ENV of 'production' in the Docker image. #4385

Merged

Conversation

chenba
Copy link
Collaborator

@chenba chenba commented Apr 26, 2018

Fixes #4326

@jaredhirsch
Copy link
Member

@chenba What's the best way to test this?

@chenba
Copy link
Collaborator Author

chenba commented Apr 26, 2018

Easiest is probably building the image locally and run docker run some_image bash -c 'echo "$NODE_ENV"' and then run docker run -e "NODE_ENV=somethingdifferent" some_image bash -c 'echo "$NODE_ENV"' to see if you get something different.

@jaredhirsch jaredhirsch merged commit 62ec921 into mozilla-services:master Apr 30, 2018
testeaxeax pushed a commit to testeaxeax/screenshots that referenced this pull request Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants