Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query user status from server #5260

Closed
ianb opened this issue Dec 20, 2018 · 1 comment

Comments

@ianb
Copy link
Contributor

commented Dec 20, 2018

We want to know if a user needs notification about the server status. We should query the status (using #5251) and decide if the user:

  1. Is using the server, and has shots with indefinite expiration
  2. Is using the server, but all shots would normally expire
  3. Has not used the server, or all shots are expired
@6a68

This comment has been minimized.

Copy link
Member

commented Dec 21, 2018

Do we really need to check the state with the server? Seems like the addon could just show one catch-all message in a modal when the user starts taking a shot, and set some local storage state when the user clicks the "OK, I understand" button

@ianb ianb self-assigned this Jan 7, 2019

ianb added a commit that referenced this issue Jan 9, 2019

Fix #5260, query user status from server
Also fix #5263, remove My Shots links for non-server-users

Fix #5261, pop open server page for people with indefinite shots

@ianb ianb closed this in 829560f Jan 10, 2019

ianb added a commit that referenced this issue Jan 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.