Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove My Shots links for non-server users #5263

Closed
ianb opened this issue Dec 20, 2018 · 0 comments

Comments

@ianb
Copy link
Contributor

commented Dec 20, 2018

Users who have not used the server (per #5260) should no longer see the My Shots button, or see Screenshots in the Library.

Note if the user somehow manages to save a shot after they use Firefox 66 with no shots, we don't need to worry about them. (This could possibly happen if they change Firefox versions, but seems like an obscure concern.)

This should be enough so that users who haven't used the server will not realize the server existed.

@ianb ianb added this to the Firefox 66 milestone Dec 20, 2018

@ianb ianb self-assigned this Jan 7, 2019

ianb added a commit that referenced this issue Jan 9, 2019

Fix #5260, query user status from server
Also fix #5263, remove My Shots links for non-server-users

Fix #5261, pop open server page for people with indefinite shots

ianb added a commit that referenced this issue Jan 9, 2019

Fix #5260, query user status from server
Also fix #5263, remove My Shots links for non-server-users

Fix #5261, pop open server page for people with indefinite shots

@ianb ianb closed this in #5297 Jan 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.