Skip to content
This repository has been archived by the owner. It is now read-only.

Add CONTRIBUTORS.md file #2388

Closed
wants to merge 1 commit into from
Closed

Conversation

@pdehaan
Copy link
Collaborator

@pdehaan pdehaan commented Mar 15, 2017

I generated this file manually using my script from #2380 (comment) — then I trimmed a couple of unwanted contributors (Bizarro and greenkeeperio-bot).

Not sure if the want to turn this into some ./bin/contributors script and hook into the Makefile so we can do this in a more automated way on each release (since we'll presumably have new contributors in the future).

Also noteworthy is that this only determines contributors based on Git commits, and doesn't include names of other people behind the scenes (such as our excellent UX team, UR team, legal team, l20n team, catering team, etc).

Fixes #2380

@pdehaan pdehaan requested a review from johngruen Mar 15, 2017
@wresuolc
Copy link
Contributor

@wresuolc wresuolc commented Mar 22, 2017

We should err on the side of being too broad here. I suggest we give up hope of this being automated and spend some time collecting names from everyone involved. I can do a first pass.

@@ -0,0 +1,20 @@
Abel 'Akronix' Serrano Juste
Copy link
Contributor

@wresuolc wresuolc Mar 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should probably be a bulleted list? GH render is showing them all on one line

Copy link
Contributor

@johngruen johngruen Mar 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wresuolc markdown needs two spaces to represent a RETURN so
Ben Ennis<space><space> not
Ben Ennis <space>

Copy link
Collaborator Author

@pdehaan pdehaan Mar 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we aren't using Markdown at all in this file, should we just rename it to CONTRIBUTORS (sans extension) so it renders as plain text?

@ianb
Copy link
Contributor

@ianb ianb commented Mar 22, 2017

Some of the people just did one-line README fixes and stuff. But if you run git shortlog you see the commits and it's pretty obvious.

As a release procedure we could do git shortlog stable..master to see if we need to make additions.

@wresuolc
Copy link
Contributor

@wresuolc wresuolc commented Mar 22, 2017

first draft @ https://public.etherpad-mozilla.org/p/pwkFIoEL4e . please edit as needed

@pdehaan
Copy link
Collaborator Author

@pdehaan pdehaan commented Mar 23, 2017

I just noticed we have an empty /CREDITS.md file in the root folder. Not sure if this is the same general concept as CONTRIBUTORS, or if we intended CREDITS.md to have something else: https://github.com/mozilla-services/screenshots/blob/master/CREDITS.md

@ianb
Copy link
Contributor

@ianb ianb commented Mar 24, 2017

I guess CREDITS.md used to refer to a library that we no longer use. I guess we should remove that file.

@ianb
Copy link
Contributor

@ianb ianb commented Mar 27, 2017

@pdehaan I'll land this one

@ianb
Copy link
Contributor

@ianb ianb commented Mar 27, 2017

I did this in PR #2492

@ianb ianb closed this Mar 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants