WebExtension migration #4864
WebExtension migration #4864
Conversation
jaredhirsch
force-pushed the
jaredhirsch:webextension-migration
branch
from
f160281
to
e6432c7
|
Looks like Circle-CI had problems building addons-linter, and I had problems with that, too. I'm not sure if I broke something with the build tooling changes. |
|
The If we reinstall |
|
LGTM. Just gotta figure out what to do about the addons-linter issue. |
|
Nice sleuthing! I'm fine to re-add |
jaredhirsch
force-pushed the
jaredhirsch:webextension-migration
branch
from
e6432c7
to
322ef92
|
|
|
@aswan Hey, would you mind taking a look at this PR? Particularly looking for feedback on the API implementation: https://github.com/mozilla-services/screenshots/pull/4864/files#diff-8e1f4fd10b786635bc10f97bcbec60e3 |
| "async": true | ||
| }, | ||
| { | ||
| "name": "uninitLibraryButton", |
aswan
Sep 11, 2018
this doesn't appear to actually be implemented?
this doesn't appear to actually be implemented?
jaredhirsch
Sep 11, 2018
Author
Member
Oh, good catch! I removed that in favor of the callOnClose. I'll yank it out of the schema, too.
Oh, good catch! I removed that in favor of the callOnClose. I'll yank it out of the schema, too.
jaredhirsch
force-pushed the
jaredhirsch:webextension-migration
branch
from
322ef92
to
48a06e5
|
Looks like I've got a rebase to do before this lands. @ianb do you have any comments on this PR? |
* The addons system, not the Screenshots addon, will be responsible for detecting changes to the 'extensions.screenshots.disabled' pref, and starting up or shutting down the Screenshots webextension when changes occur (bug 1488971). * The LibraryButton code has been moved from bootstrap.js into the embedded API. We'll be able to remove this code as soon as Library menu items can be declared from the WebExtension manifest (bug 1366389). * Move addon/webextension to webextension, update all the refs. * Update makefile and build tools. * Remove the script that deletes duplicate locales (en_CA) at build time, because this breaks running with web-ext, and there is code to handle duplicate locales inside export_mc.py already. * Keep `jpm` because `addons-linter` seems to depend on it * Still TODO: README files and docs directory not yet updated
jaredhirsch
force-pushed the
jaredhirsch:webextension-migration
branch
from
48a06e5
to
e79810c
Having some trouble getting addons-linter to install, and had to manually delete and re-add package-lock.json (am I doing this wrong?), but this otherwise seems to work for me locally.
Things to note, from the actual commit:
Migrate Screenshots to pure WebExtension
The addons system, not the Screenshots addon, will be responsible for
detecting changes to the 'extensions.screenshots.disabled' pref, and
starting up or shutting down the Screenshots webextension when changes
occur (bug 1488971).
The LibraryButton code has been moved from bootstrap.js into the
embedded API. We'll be able to remove this code as soon as Library
menu items can be declared from the WebExtension manifest (bug 1366389).
Move addon/webextension to webextension, update all the refs.
Update makefile and build tools.
Remove the script that deletes duplicate locales (en_CA) at build
time, because this breaks running with web-ext, and there is code to
handle duplicate locales inside export_mc.py already.
Still TODO: README files and docs directory not yet updated