Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hold] Fix #5235, enable pageAction on reader mode #5282

Merged
merged 1 commit into from Jan 25, 2019

Conversation

@ianb
Copy link
Contributor

commented Jan 4, 2019

This PR will fail, but it's necessary to enable the pageAction startup method. I think the Firefox version on CI doesn't support the about:reader* manifest.json action.

@6a68

This comment has been minimized.

Copy link
Member

commented Jan 25, 2019

It's probably some pref we aren't setting inside the profile when running on CI, but yeah, we'll definitely need this for the export.

@6a68

6a68 approved these changes Jan 25, 2019

@6a68

This comment has been minimized.

Copy link
Member

commented Jan 25, 2019

/me ignores insanity of package-lock diff

@6a68 6a68 merged commit 242f4a2 into master Jan 25, 2019

0 of 2 checks passed

ci/circleci: build Your tests failed on CircleCI
Details
ci/circleci: test Your tests failed on CircleCI
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.