Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5244, use incognito: spanning in manifest #5294

Merged
merged 1 commit into from Jan 7, 2019

Conversation

@ianb
Copy link
Contributor

commented Jan 7, 2019

Soon Firefox will disable add-ons without this, or require people to opt-in

I believe this follows @mixedpuppy's recommendation

Fix #5244, use incognito: spanning in manifest
Soon Firefox will disable add-ons without this, or require people to opt-in

@ianb ianb requested a review from 6a68 Jan 7, 2019

@6a68

6a68 approved these changes Jan 7, 2019

Copy link
Member

left a comment

LGTM

@6a68 6a68 merged commit 3314638 into master Jan 7, 2019

2 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details

@6a68 6a68 deleted the incognito-spanning branch Jan 7, 2019

@mixedpuppy

This comment has been minimized.

Copy link

commented Jan 8, 2019

Soon Firefox will disable add-ons without this, or require people to opt-in

I believe this follows @mixedpuppy's recommendation

It doesn't hurt, but it wasn't necessary. System addons will continue to run as-is and still have private browsing access.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.