Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix #5260, query user status from server #5297
Also fix #5263, remove My Shots links for non-server-users
Fix #5261, pop open server page for people with indefinite shots
This was a bit of an annoying patch, as anything involving state, several conditionals, timing, and failure conditions of all the above will be. This doesn't include a fix for #5262, but that will be a fairly simple addition to this change.
6a68 left a comment •
Opening a tab when the user's in the middle of some other task seems kind of aggressive / hostile to me. I'd suggest just firing a desktop notification at startup, with no delay.
Editorial comments aside, LGTM as written, though QA should test the flow carefully, particularly with no network, to make sure the error cases work out ok.
We'll discuss the popup question in #5298
I'm landing this despite the test failure [I've disabled the bad test] (which I can't quite figure out – in one situation the autoselection isn't working, even though it's working elsewhere). These tests will go away with #5256, which will happen very soon, so doing lots of work to fix them when they are going to be deleted or changed doesn't seem useful.