Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics improvements #5315

Merged
merged 2 commits into from Jan 17, 2019

Conversation

@ianb
Copy link
Contributor

commented Jan 15, 2019

No description provided.

ianb added some commits Jan 15, 2019

Fix #5293, stop sending metrics if server isn't available
Also adds logic to not send timing information if server is unavailable
Fix #5264, only send analytics for 10% of users
This random generates a number for users when Screenshots is loaded, then saves that number, to determine who will actually send metrics.

@ianb ianb requested a review from 6a68 Jan 15, 2019

@6a68

6a68 approved these changes Jan 17, 2019

Copy link
Member

left a comment

LGTM

@6a68 6a68 merged commit 52bda28 into master Jan 17, 2019

2 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details

@6a68 6a68 deleted the metrics-improvements branch Jan 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.