From d7f7240d409287ca55168c2a5823f712acc0acaa Mon Sep 17 00:00:00 2001 From: Chris Hartjes Date: Wed, 7 Feb 2018 10:30:26 -0500 Subject: [PATCH 1/2] Removes references to graph on the home page, which is no longer in use. Reference: https://bugzilla.mozilla.org/show_bug.cgi?id=1434902 --- e2e-tests/pages/home_page.py | 2 -- .../crashstats/static/crashstats/css/screen.less | 7 ------- 2 files changed, 9 deletions(-) diff --git a/e2e-tests/pages/home_page.py b/e2e-tests/pages/home_page.py index baf1721b5a..e48b9eef3c 100644 --- a/e2e-tests/pages/home_page.py +++ b/e2e-tests/pages/home_page.py @@ -13,12 +13,10 @@ class CrashStatsHomePage(CrashStatsBasePage): URL_TEMPLATE = '/' - _graph_loading_locator = (By.CSS_SELECTOR, '#homepage-graph .loading') _release_channels_locator = (By.CSS_SELECTOR, '.release_channel') def wait_for_page_to_load(self): super(CrashStatsHomePage, self).wait_for_page_to_load() - self.wait.until(lambda s: not self.is_element_present(*self._graph_loading_locator)) return self @property diff --git a/webapp-django/crashstats/crashstats/static/crashstats/css/screen.less b/webapp-django/crashstats/crashstats/static/crashstats/css/screen.less index ce067072a7..85ca1255c6 100644 --- a/webapp-django/crashstats/crashstats/static/crashstats/css/screen.less +++ b/webapp-django/crashstats/crashstats/static/crashstats/css/screen.less @@ -679,13 +679,6 @@ div.admin { height: 18px; vertical-align: middle; } -#homepage-graph { - position: relative; -} -.homepage-graph-legend { - width: 100%; - text-align: center; -} /* simplebox css */ #simplebox { display:none; From 223e771382505e8d3e0cf2d6fcec39b61bf5dd2c Mon Sep 17 00:00:00 2001 From: Chris Hartjes Date: Wed, 7 Feb 2018 10:30:26 -0500 Subject: [PATCH 2/2] Fix bug 1434902: remove references to graph no longer being used on home page --- e2e-tests/pages/home_page.py | 2 -- .../crashstats/static/crashstats/css/screen.less | 7 ------- 2 files changed, 9 deletions(-) diff --git a/e2e-tests/pages/home_page.py b/e2e-tests/pages/home_page.py index baf1721b5a..e48b9eef3c 100644 --- a/e2e-tests/pages/home_page.py +++ b/e2e-tests/pages/home_page.py @@ -13,12 +13,10 @@ class CrashStatsHomePage(CrashStatsBasePage): URL_TEMPLATE = '/' - _graph_loading_locator = (By.CSS_SELECTOR, '#homepage-graph .loading') _release_channels_locator = (By.CSS_SELECTOR, '.release_channel') def wait_for_page_to_load(self): super(CrashStatsHomePage, self).wait_for_page_to_load() - self.wait.until(lambda s: not self.is_element_present(*self._graph_loading_locator)) return self @property diff --git a/webapp-django/crashstats/crashstats/static/crashstats/css/screen.less b/webapp-django/crashstats/crashstats/static/crashstats/css/screen.less index ce067072a7..85ca1255c6 100644 --- a/webapp-django/crashstats/crashstats/static/crashstats/css/screen.less +++ b/webapp-django/crashstats/crashstats/static/crashstats/css/screen.less @@ -679,13 +679,6 @@ div.admin { height: 18px; vertical-align: middle; } -#homepage-graph { - position: relative; -} -.homepage-graph-legend { - width: 100%; - text-align: center; -} /* simplebox css */ #simplebox { display:none;