Fixes bug 828906 - Remove obsolete code using branches table. #1046

Merged
merged 1 commit into from Jan 30, 2013

Conversation

Projects
None yet
2 participants
Contributor

adngdb commented Jan 11, 2013

@ghost ghost assigned lonnen Jan 16, 2013

Contributor

lonnen commented Jan 23, 2013

@adriangaudebert - three models in the PHP webapp references branches (search, branch, and report). Should this wait until that is decommissioned?

Contributor

adngdb commented Jan 23, 2013

@lonnen The UI doesn't show branches anymore, and I don't think the branch model is used. For more security we can indeed wait until I have removed all those references from the WebApp as well, especially as this is really low priority.

@adngdb adngdb closed this Jan 23, 2013

Contributor

lonnen commented Jan 23, 2013

I did some local testing and this should be ok to land. The change looks fine if you wanted to reopen.

@adngdb adngdb reopened this Jan 25, 2013

Contributor

adngdb commented Jan 25, 2013

@lonnen I removed the obsolete code from the WebApp as well. The branch model doesn't touch the branches table but has other versions-related features, that's why I'm not removing/editing it.

lonnen added a commit that referenced this pull request Jan 30, 2013

Merge pull request #1046 from AdrianGaudebert/828906-remove-branches-…
…support

Fixes bug 828906 - Remove obsolete code using branches table.

@lonnen lonnen merged commit f0c4986 into mozilla-services:master Jan 30, 2013

1 check passed

default Jenkins build 'socorro-github' #411 has succeeded
Details
Contributor

lonnen commented Jan 30, 2013

👍

rhelmer pushed a commit to rhelmer/socorro that referenced this pull request Sep 6, 2013

Merge pull request #1046 from JasnaPaka/master
L10N update for Czech (cs)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment