DO NOT MERGE rabbitmq WIP #1223

Closed
wants to merge 17 commits into
from

Conversation

Projects
None yet
4 participants
@selenamarie
Contributor

selenamarie commented May 3, 2013

No description provided.

twobraids and others added some commits May 1, 2013

Handle unspecified finished_funcs a different way.
This way, we save a bit of code, and the number of args finished_func takes is self-documenting.
Integrating our rabbitmq patches:
* Added extra checking for whether we're in a transaction
* bugfix in new_crash_source, and make durable queues
* Getting integration tests working, and a new config
* Removing extraneous tuple in processor_app.py

Also includes working configs for HBase and RabbitMQ locally
@selenamarie

This comment has been minimized.

Show comment Hide comment
@selenamarie

selenamarie May 3, 2013

Contributor

Two issues:

  • One Erik can comment on
  • Second issue: Selena will work on this: transaction management + postgres -- we modified something that affects in_transaction() and causes tests to fail. This may have actually fixed a bug but need to investigate further to ensure that we are getting the correct behavior for this function after the change to the transaction manager.
Contributor

selenamarie commented May 3, 2013

Two issues:

  • One Erik can comment on
  • Second issue: Selena will work on this: transaction management + postgres -- we modified something that affects in_transaction() and causes tests to fail. This may have actually fixed a bug but need to investigate further to ensure that we are getting the correct behavior for this function after the change to the transaction manager.
+
+ def new_crashes(self):
+ channel = self.rabbitmq.connection()
+ data = channel.basic_get(queue="socorro.priority")

This comment has been minimized.

Show comment Hide comment
@erikrose

erikrose May 6, 2013

Contributor

I'd really like to see this repetition addressed, as I mentioned in #1211, before we merge.

@erikrose

erikrose May 6, 2013

Contributor

I'd really like to see this repetition addressed, as I mentioned in #1211, before we merge.

erikrose and others added some commits May 6, 2013

Do the conversion of crash IDs to arg/kwarg pairs in the right place.
That is, in the legacy crash source rather than in the processor app (and there assuming empty kwargs and a single arg).
Merge selenamarie/merge-rabbitmq into rmq_crash_source so Selena can …
…do a FF merge of this into that, and we can also go into the bright future together.

The merge conflict was getting her down.
Merge pull request #5 from erikrose/rmq_crash_source
Get straight who should be tuple-ifying things
Merge pull request #6 from brandonsavage/merge-rabbitmq
Adding a check for supporting transactions to the context managers.
@selenamarie

This comment has been minimized.

Show comment Hide comment
@selenamarie

selenamarie May 10, 2013

Contributor

Going to close this in favor of the mozilla/socorro branch of the same name.

Contributor

selenamarie commented May 10, 2013

Going to close this in favor of the mozilla/socorro branch of the same name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment