Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[Ready to land] Detecting suspicious/explosive crashes #1394
Still work in progress. But this should be the idea for the cron job. Feedback will be nice
Right now the model is fairly "dumb". Smarter models could be developed but most of them are based on the existing math (and code framework) and should be fairly easy to add in.
Note about code review: There is a blob of math somewhere in this PR (not sure what the final structure will look like). There are some comments describing them and links to the original implementations/papers. As (if) I develop more complicated models, more math functions (blobs) will be added into the mix. While for some of these stuff I don't have theoretical verifications that I did this correctly, I did experimentally verify them to the best of my abilities (results are in docstrings/comments). If someone wants to mathematically prove it and tell me I'm wrong, please do so :).
Almost ready for merge. There are some optimizations that needs to be done. Though those might be best with Bugzilla bugs.
Some stuff that we can refine (possibly at a later time), in no particular order.
These, with possibly the exception of the first one, should probably be bugzilla bugs.
This PR has some meat on it. Most of the time we'd land this is stages -- cron + database, middleware service, then UI. I left a few things to address, but we should get other sets of eyes on this as well.
It would be nice if @selenamarie could check the migration and give some advice about reports vs reports clean.
I noticed you got two test failures.
One is weird. The one about the private tempdir. I wouldn't be surprised that that'll just work next time you try.
However, the other test you have there is failing bad. I'm sure you can figure it out.
Once you figure out the test and jenkins passes; r+