Use minified files for d3 #1914

Merged
1 commit merged into from Feb 25, 2014

Conversation

Projects
None yet
2 participants
@ghost

ghost commented Feb 25, 2014

No description provided.

Contributor

peterbe commented Feb 25, 2014

I think you should attach it to a bug actually. Since it's already made it to stage.

Also, I think you should do the same with nv.d3.min.css (or whatever it's called)

Also, I think you should git rm the non-minified files now.

Contributor

peterbe commented Feb 25, 2014

Can you use https://github.com/novus/nvd3/blob/master/nv.d3.min.css instead. I see no benefit in keeping the source one.

@ghost

ghost commented Feb 25, 2014

I was using the min file from http://d3js.org/ zip download. But let me switch to that

@ghost

ghost commented Feb 25, 2014

Ah i see you meant the CSS, done

Contributor

peterbe commented Feb 25, 2014

Where is the new nv.d3.min.css file?

webapp-django/crashstats/crashstats/templates/crashstats/gccrashes.html
@@ -5,9 +5,7 @@
<link rel="stylesheet" type="text/css" href="{{ static('crashstats/css/jquery-ui-1.10.3/flick/jquery.ui.custom.min.css') }}" media="screen" />
<link rel="stylesheet" type="text/less" href="{{ static('crashstats/css/gccrashes.less') }}" media="screen" />
{% endcompress %}
- {% compress css %}
<link rel="stylesheet" type="text/css" href="{{ static('crashstats/css/lib/nv.d3.css') }}" media="screen" />
@peterbe

peterbe Feb 25, 2014

Contributor

This needs to change too.

Contributor

peterbe commented Feb 25, 2014

r+

ghost pushed a commit that referenced this pull request Feb 25, 2014

Merge pull request #1914 from ossreleasefeed/bug915317-display-total-…
…volume-of-gccrashes

Fix Bug 976674, use minified files for d3

@ghost ghost merged commit f239902 into mozilla-services:master Feb 25, 2014

1 check passed

default Jenkins build 'socorro-github' #2857 has succeeded
Details

@ghost ghost deleted the schalkneethling:bug915317-display-total-volume-of-gccrashes branch Feb 25, 2014

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment