why did this ever get removed #1925

Merged
merged 1 commit into from Mar 1, 2014

Conversation

Projects
None yet
3 participants
Contributor

lonnen commented Mar 1, 2014

No description provided.

lonnen added a commit that referenced this pull request Mar 1, 2014

Merge pull request #1925 from lonnen/lolwut
why did this ever get removed

@lonnen lonnen merged commit 5c7995e into mozilla-services:master Mar 1, 2014

1 check was pending

default Jenkins build 'socorro-github' #2903 is running
Details

@lonnen lonnen deleted the lonnen:lolwut branch Mar 1, 2014

Contributor

lonnen commented Mar 1, 2014

noticed later that its checked into vendor local.

Contributor

peterbe commented on 31fb001 Mar 5, 2014

Are we using this file for anything? If so that's a bug. (not in the far future but for now it is)

Contributor

rhelmer replied Mar 5, 2014

@peterbe yes, we build and ship a virtualenv and point Apache mod_wsgi at it.

Contributor

peterbe replied Mar 6, 2014

@rhelmer that's bad. We have requests (amongst many other things) in ./webapp-django/vendor and ./webapp-django/vendor-local. That's the definitive place to put dependencies. Due to a couple of funfactory lines in manage.py it makes sure those two directories trumps anything in the environment.

Actually it's quite harmless then. So if you have requests version X in the virtualenv (or system python for that matter) and you have requests version Y in vendor-local, then django will pick up requests version Y.

It is by far the worse decision every made for playdoh to try to maintain a requirements file when what really matters is the vendor directories. That's why I always wipe it from all but compiled stuff. At least I try to.

Contributor

rhelmer replied Mar 6, 2014

@peterbe stage has been busted for the last half-week because the vendor libs haven't been working, and nobody noticed until we did a clean build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment