New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes bug 1400085 - add stdext::hash_map<T>::.* to prefix list #3992

Merged
merged 1 commit into from Sep 15, 2017

Conversation

Projects
None yet
2 participants
@willkg
Collaborator

willkg commented Sep 15, 2017

Here's the change in signatures:

app@90ae9bd26804:/app$ python -m socorro.signature 7b1e019c-68c0-4c55-8ddc-99fe30170913
Crash id: 7b1e019c-68c0-4c55-8ddc-99fe30170913
Original: stdext::hash_map<T>::operator[]
New:      stdext::hash_map<T>::operator[] | mozilla::ipc::IToplevelProtocol::ShmemCreated
Same?:    False
@willkg

This comment has been minimized.

Show comment
Hide comment
@willkg

willkg Sep 15, 2017

Collaborator

@nnethercote Does that change in signature look good?

Collaborator

willkg commented Sep 15, 2017

@nnethercote Does that change in signature look good?

@nnethercote

This comment has been minimized.

Show comment
Hide comment
@nnethercote

nnethercote Sep 15, 2017

Contributor

Yes! Thank you.

Contributor

nnethercote commented Sep 15, 2017

Yes! Thank you.

@willkg willkg merged commit e635240 into mozilla-services:master Sep 15, 2017

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@willkg willkg deleted the willkg:1400085-stdext-hash-map branch Sep 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment