bug 1402037 - improve shutdownhang signatures #4017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Examples of changes in crashes from this change here: https://bugzilla.mozilla.org/show_bug.cgi?id=1402037#c23 |
We have a number of shutdownhang signatures where the stack is rife with "uninteresting" bits such that the signature gets truncated before getting to something interesting or relevant or actionable. This adds a bunch of things to the irrelevant list such that they don't show up in the signature. I did some regression testing and these strings only show up in shutdownhang crashes. If that changes, we should rethink them on a string-by-string basis.
willkg
commented
Sep 26, 2017
| nsThread::nsChainedEventQueue::GetEvent | ||
| nsThread::ProcessNextEvent | ||
| NS_ProcessNextEvent | ||
| NtWaitForKeyedEvent |
There was a problem hiding this comment.
I should collapse this one like the following one.
|
@lonnen If we can, I'd love to get this landed and tested before tomorrow. Then we can push it to -prod tomorrow. |
|
R+ |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a number of shutdownhang signatures where the stack is rife with
"uninteresting" bits such that the signature gets truncated before getting to
something interesting or relevant or actionable.
This adds a bunch of things to the irrelevant list such that they don't show up
in the signature.
I did some regression testing and these strings only show up in shutdownhang
crashes. If that changes, we should rethink them on a string-by-string basis.