bug 1671276: process breadcrumbs and show on details page #5650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willkg
commented
Jan 9, 2021
The crash reporter in android-components which Fenix uses captures
breadcrumbs and puts it in the Breadcrumbs annotation.
This adds a processor rule to validate it and add it to the processed
crash and then display it in the Details of the report view.
Note that we tried to use the same structure that Sentry uses, however
Sentry's breadcrumbs structure looks like this:
{
"breadcrumbs": {
"values": [
crumb,
crumb,
crumb,
]
}
}
and ours look like this:
{
"breadcrumbs": [
crumb,
crumb,
crumb,
]
}
This code normalizes the Sentry form to ours because the validation is
easier that way. In the future, we should make sure that's what we want
to do and adjust accordingly.
This marks it as protected data, so if you don't have access to that,
you can't see it.
This doesn't make it searchable. I decided not to deal with that until I
know more about how people want to search it (or even if people do want
to search it).
willkg
commented
Jan 9, 2021
| missing_keys = required_keys - (required_keys & set(item.keys())) | ||
| if missing_keys: | ||
| missing_keys = ", ".join(sorted(missing_keys)) | ||
| raise MalformedBreadcrumbs(f"item {i} missing keys: {missing_keys}") |
There was a problem hiding this comment.
At some point, I want to do a bunch of schema stuff and when I do that, we'll redo this with that.
willkg
commented
Jan 9, 2021
| @@ -63,54 +63,6 @@ table { | |||
| } | |||
| } | |||
|
|
|||
| &.captioned-data-table { | |||
There was a problem hiding this comment.
This isn't used anywhere, so I nixed it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The crash reporter in android-components which Fenix uses captures
breadcrumbs and puts it in the Breadcrumbs annotation.
This adds a processor rule to validate it and add it to the processed
crash and then display it in the Details of the report view.
This marks it as protected data, so if you don't have access to that,
you can't see it.
This doesn't make it searchable. I decided not to deal with that until I
know more about how people want to search it (or even if people do want
to search it).