Skip to content

/ syncstorage-rs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.7.1 batch commit can exceed 20k max mutations #869

Closed
pjenvey opened this issue Oct 20, 2020 · 1 comment
Closed

0.7.1 batch commit can exceed 20k max mutations #869

pjenvey opened this issue Oct 20, 2020 · 1 comment
Assignees
@pjenvey
Labels
5 bug p1
Projects
Services Engineering

Comments

@pjenvey
Copy link
Member

@pjenvey pjenvey commented Oct 20, 2020

Seen here:

https://sentry.prod.mozaws.net/operations/syncstorage-prod/issues/9820467/

Likely the changes for quota support (even when disabled) seem to have changed the batch commit's write pattern.
@pjenvey pjenvey added this to Backlog: Misc in Services Engineering via automation Oct 20, 2020
@pjenvey
Copy link
Member Author

@pjenvey pjenvey commented Oct 20, 2020

It looks like batch commit originally called touch_collection_async to begin. Now it calls update_collection_async to begin instead, with an extra call to the new update_user_collection_quotas at the end.

The last time I calculated mutations there was little to no room for extras, so I'm guessing the new, additional update_user_collection_quotas call puts it over.
@pjenvey pjenvey moved this from Backlog: Misc to Scheduled in Services Engineering Oct 20, 2020
@pjenvey pjenvey self-assigned this Oct 23, 2020
@pjenvey pjenvey moved this from Scheduled to In Progress in Services Engineering Oct 23, 2020
pjenvey added a commit that referenced this issue Oct 29, 2020
@pjenvey
fix: avoid extra quota related work in batch commit
Verified
This commit was signed with the committer’s verified signature.
pjenvey Philip Jenvey
GPG key ID: 5B9F83DE4F7EB7FA Learn about vigilant mode.
51c3bda 
and document batch commit's mutations

Closes #869
This was referenced Oct 29, 2020
Open
Merged
@pjenvey pjenvey closed this in #877 Oct 29, 2020
Services Engineering automation moved this from In Progress to Done Oct 29, 2020
@jrconlin jrconlin mentioned this issue Oct 29, 2020
Merged
@tublitzed tublitzed moved this from Done to Archived in Services Engineering Nov 2, 2020
@pjenvey pjenvey mentioned this issue Mar 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pjenvey pjenvey

Labels
5 bug p1
Projects
Services Engineering
  
Archived
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

fix: avoid extra quota related work in batch commit
chore: tag 0.8.0
1 participant
@pjenvey