Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Config file is useless #13

Closed
xni opened this Issue Dec 14, 2012 · 4 comments

Comments

Projects
None yet
2 participants

xni commented Dec 14, 2012

Because all settings is overwritten by default ones.

See (as for master at 835ac57) run.py

Line 130:
(Pdb) print args
Namespace(backend='localhost:80', backlog=8192, behavior='100:dummy', behavior_delay_before=True, behavior_delay_sleep=1, behavior_error_inject=False, behavior_error_warmup=0, bufsize=8192, config='../vaurein.conf', http=False, http_host='localhost', http_port=8080, loglevel='info', logoutput='-', pool_max_size=100, pool_timeout=30, protocol='tcp', protocol_http_buffer=8124, protocol_http_keep_alive=False, protocol_http_reuse_socket=False, protocol_memcache_buffer=8124, protocol_memcache_keep_alive=False, protocol_memcache_reuse_socket=False, protocol_mysql_buffer=8124, protocol_mysql_reuse_socket=False, protocol_redis_buffer=8124, protocol_redis_keep_alive=False, protocol_redis_reuse_socket=False, protocol_smtp_buffer=8124, protocol_smtp_reuse_socket=False, protocol_tcp_buffer=8124, protocol_tcp_keep_alive=False, protocol_tcp_reuse_socket=False, proxy='localhost:8000', statsd.enabled=False, statsd.host='localhost', statsd.port=8125, statsd.prefix='vaurien', statsd.sample_rate=1.0, stay_connected=False, sync=False, timeout=30, version=False)

backend is already in args, because it is in default_settings

This is my settings after parsing config

Line 147:
(Pdb) print settings
{'statsd.enabled': False, 'vaurien.behavior': '100:normal', 'statsd.host': 'localhost', 'vaurien.proxy': 'localhost:8000', 'vaurien.timeout': 30, 'vaurien.bufsize': 8192, 'vaurien.sync': False, 'vaurien.stay_connected': False, 'vaurien.protocol': 'tcp', 'vaurien.pool_timeout': 30, 'statsd.sample_rate': 1.0, 'statsd.prefix': 'vaurien', 'vaurien.backend': '19.20.21.22:5432', 'config': <vaurien.config.Config instance at 0x7f92e832add0>, 'statsd.port': 8125, 'vaurien.backlog': 8192, 'vaurien.pool_max_size': 100}

But after merge backend = 19.20.21.22:5432 is lost (on line 162), because it is already in args.

Collaborator

tarekziade commented Dec 14, 2012

Good catch thx

@ghost ghost assigned tarekziade Dec 14, 2012

Collaborator

tarekziade commented Dec 14, 2012

@xni can you try with the current master please ? If it works I'll cut a release

xni commented Dec 14, 2012

Yes, it works.
I haven't read the code, but thanks!

Collaborator

tarekziade commented Dec 14, 2012

1.4 released with this fix.

@tarekziade tarekziade closed this Dec 14, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment