Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distribution through F-Droid #1050

Closed
rugk opened this Issue Oct 3, 2017 · 14 comments

Comments

Projects
None yet
8 participants
@rugk
Copy link

rugk commented Oct 3, 2017

It would be nice to have this app on F-Droid.

@joechengla

This comment has been minimized.

Copy link

joechengla commented Oct 5, 2017

thanks for the feedback. APKs will be made available on github soon when we start opening up

@rugk

This comment has been minimized.

Copy link
Author

rugk commented Oct 5, 2017

APKs are one thing. F-Droid is another. See: https://f-droid.org/docs/Submitting_to_F-Droid_Quick_Start_Guide/

Firefox Focus/Klar is already on F-Droid, BTW.

@Conjuror Conjuror added the S1 label Oct 6, 2017

@chianger chianger added NeedTriage S3 and removed S1 NeedTriage labels Oct 9, 2017

@chianger

This comment has been minimized.

Copy link
Contributor

chianger commented Nov 9, 2017

For non-GooglePlay distribution we're counting on https://github.com/mozilla-tw/Rocket/releases
at this moment.

@chianger chianger changed the title F-Droid Distribution through F-Droid Nov 9, 2017

@Rudloff

This comment has been minimized.

Copy link

Rudloff commented Dec 17, 2017

The app seems to have some non-free dependencies: https://github.com/mozilla-tw/Rocket/blob/master/app/build.gradle#L166
This means it can't be included in F-Droid unless there is an option to build the app without these dependencies.

@dimqua

This comment has been minimized.

Copy link
Contributor

dimqua commented Nov 3, 2018

I've openned a request here: https://gitlab.com/fdroid/rfp/issues/786

The app has so many non-free deps, so I afraid It can't be included without a specific FOSS build flavour. :-(

@Rudloff

This comment has been minimized.

Copy link

Rudloff commented Feb 27, 2019

I managed to build the app without Google Analytics or Firebase (you can have a look at the changes I made here) so it now complies with our inclusion policy.

The only thing that is missing now is your approval. Would you be OK with us publishing the app with these changes?

@mTwTm

This comment has been minimized.

Copy link
Member

mTwTm commented Mar 7, 2019

I think I can take a look at the change when I have some time (currently busy working on other things.)
I'll take a look at if it's easy to create a flavor that is suitable for fdroid with your change in the lite repository, if no, I'll still try to take a look at if we can build one with your changes.

@mTwTm mTwTm self-assigned this Mar 7, 2019

@mTwTm

This comment has been minimized.

Copy link
Member

mTwTm commented Mar 7, 2019

Oh it's actually some yml? I'm not sure if I'm familiar with these prebuild techniques and how they work on fdroid but I think this seems a lot simpler than I expected. Will reply soon when I figure out.

@mTwTm

This comment has been minimized.

Copy link
Member

mTwTm commented Mar 7, 2019

I think this workaround is workable, I'll take a look at if the built version with these workaround will lead to any trouble when I have some more time.

All green! I'll talk to the owner of the product and check if there's anything else he/she has concern with tomorrow.

Just to make sure: so all builds if this apk on fdroid will pull directly from Github with this setting right? All future changes will be applied as long as we don't break these pre-builds and we dont need to provide a signed version of the built apk?

@Rudloff

This comment has been minimized.

Copy link

Rudloff commented Mar 7, 2019

Thank you for taking the time to look at this!

Yes, our build server fetches the latest Git tag, applies our changes and builds the APK ; then we sign it with our own key and publish it.

@mTwTm

This comment has been minimized.

Copy link
Member

mTwTm commented Mar 11, 2019

So I think there's no red flag from the owner but we're also making sure other functions such as legal is aware of this change. I'll get back when it's all green.

@mTwTm mTwTm assigned joechengla and unassigned mTwTm Mar 18, 2019

@mTwTm

This comment has been minimized.

Copy link
Member

mTwTm commented Mar 29, 2019

@joechengla any update?

@rugk rugk closed this Mar 30, 2019

@rugk

This comment has been minimized.

Copy link
Author

rugk commented Mar 30, 2019

As for the ID: So Firefox Rocket == Firefox Light, okay…

@rugk rugk referenced this issue Apr 13, 2019

Open

F-Droid #643

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.