Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set minimum OSX version to 10.10 #1065

Merged
merged 1 commit into from Dec 5, 2017

Conversation

Projects
None yet
2 participants
@lissyx
Copy link
Collaborator

commented Dec 4, 2017

Fixes #1055

@lissyx lissyx self-assigned this Dec 4, 2017

@lissyx lissyx requested a review from reuben Dec 4, 2017

@lissyx

This comment has been minimized.

Copy link
Collaborator Author

commented Dec 4, 2017

It seems to run for me, but I'd like more testing being done :)

@reuben

This comment has been minimized.

Copy link
Member

commented Dec 4, 2017

I don't have an older version of macOS to test with. If it works for the users who reported problems, r=me.

Alexandre Lissy

@lissyx lissyx force-pushed the lissyx:osx-minversion branch from 0a64458 to e0a96ef Dec 5, 2017

@lissyx

This comment has been minimized.

Copy link
Collaborator Author

commented Dec 5, 2017

So, lucky. I had to source a new MacBook Pro to add build capacity. Turned out this was running an OSX 10.11, so I took my chance on a brand-new-out-of-the-box-OSX 10.11:

$ sudo easy_install pip
$ pip install --user virtualenv
$ virtualenv ds-osx10.11-test
$ source ds-osx10.11-test/bin/activate
$ pip install --upgrade https://queue.taskcluster.net/v1/task/BepAdAZyT7iCAl-UpYJHeg/runs/0/artifacts/public/deepspeech-0.1.0-cp27-cp27m-macosx_10_10_x86_64.whl

And I have a wheel that seems to work :)

@reuben

reuben approved these changes Dec 5, 2017

@lissyx lissyx merged commit 63ac19c into mozilla:master Dec 5, 2017

1 check failed

Taskcluster (pull_request) TaskGroup: failure
Details

@lissyx lissyx deleted the lissyx:osx-minversion branch Sep 26, 2018

@lock

This comment has been minimized.

Copy link

commented Jan 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Jan 2, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.