Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Allow Settings Guard changes to be reverted #4
This message is copied over from Issue #3
Currently when the Guard reports the changes in settings, the non-advanced user might have doubts - what to do.
Generally, I don't expect changing these settings to break any add-ons. And users that install this extension are already looking for something that helps them reset their settings, so I don't think that they will second-guess themselves too much when faced with the option to reset the settings.
I don't know if this would be useful, specially for non-advanced users. They won't know what keyword.URL or the user agent string are, but they will notice the faulty behavior caused by add-ons that change them. I don't see this sort of user setting it back to their previously modified values. As for the homepage, it is only reset in very specific circumstances, and it's not difficult to set it to whatever the user wants.
Worst case, they can reinstall the extension if they want the settings changes to happen again. However, we're generally aiming for users who got rid of the extension and are now stuck with settings changes they can't reset.
This comment has been minimized.
This comment has been minimized.Show comment Hide comment
Let I explain the situation:
It makes sense that you got a warning from Browser Protect, since it is designed to warn about those things. In fact, Settings Guard should be redundant since Browser Protect goes a few steps further in terms of features. The problem here is that you have 2 add-ons installed that do very similar things, so they step into each other's toes.
Generally, installing the add-on again should change the settings again. I don't know the details about Superstart, though. You should, however, understand that the add-on is meant to reset your settings. You get the option to not reset them, but you are installing it for that specific purpose. I think that making it possible to undo these changes would just make everything more difficult to understand.
Absolutely. That's the reason it's not fully reviewed on AMO and it's not being very heavily promoted. We need to work on the messages and user experience so that everything is as clear as possible. For now it's just an initial version.
Thank you for all the feedback. I'll keep this issue open to give it more thought.