New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export static theme add-on .xpi from current theme settings #494

Merged
merged 2 commits into from Oct 9, 2018

Conversation

Projects
None yet
3 participants
@lmorchard
Copy link
Member

lmorchard commented Oct 5, 2018

  • Enable Export button in AppHeader

  • New export.js module with client-side support to assemble a .zip/.xpi
    static theme add-on

  • Add stub component for ExportThemeDialog

  • Add Redux store support for theme export progress and result

  • Extract shared convertToBrowserTheme code from add-on for producing
    real theme from Redux data

  • Add jszip and redux-promise dependencies

  • Turn off some eslint rules that seem annoying

Issue #93

@lmorchard

This comment has been minimized.

Copy link
Member

lmorchard commented Oct 5, 2018

To use this, you should be able to hit "Export" in the header and then see links to theme.zip & theme.xpi in the browser preview area. They're the same file, but I found .zip easier to download and open to look at than .xpi. But, you can use the .xpi in about:debugging to load up the theme

capture

This could definitely use some UX improvements. I'm continuing to tinker to see if I can just have a download automatically start, rather than displaying the links.

@lmorchard

This comment has been minimized.

Copy link
Member

lmorchard commented Oct 5, 2018

Oh yeah, and we could do with adding some way to let the user set the name, version, etc for the add-on on export.

@lmorchard lmorchard force-pushed the lmorchard:93-theme-export branch from 12a49a5 to 8aafc9c Oct 8, 2018

lmorchard added some commits Oct 5, 2018

Export static theme add-on .xpi from current theme settings
- Enable Export button in AppHeader

- New export.js module with client-side support to assemble a .zip/.xpi
  static theme add-on

- Add stub component for ExportThemeDialog

- Add Redux store support for theme export progress and result

- Extract shared convertToBrowserTheme code from add-on for producing
  real theme from Redux data

- Add jszip and redux-promise dependencies

- Turn off some eslint rules that seem annoying

- Webpack config tweak for dynamic import bundle name

- Add babel dynamic import plugin

Issue #93

@lmorchard lmorchard force-pushed the lmorchard:93-theme-export branch from 8aafc9c to 99cc888 Oct 8, 2018

@meandavejustice

This comment has been minimized.

Copy link
Member

meandavejustice commented Oct 9, 2018

This works for me, really cool feature.

@meandavejustice meandavejustice merged commit 2b5cdf5 into mozilla:master Oct 9, 2018

1 check passed

ci/circleci: build_and_test Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment