Export static theme add-on .xpi from current theme settings #494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
To use this, you should be able to hit "Export" in the header and then see links to theme.zip & theme.xpi in the browser preview area. They're the same file, but I found .zip easier to download and open to look at than .xpi. But, you can use the .xpi in about:debugging to load up the theme
This could definitely use some UX improvements. I'm continuing to tinker to see if I can just have a download automatically start, rather than displaying the links. |
Contributor
Author
|
Oh yeah, and we could do with adding some way to let the user set the name, version, etc for the add-on on export. |
lmorchard
force-pushed
the
93-theme-export
branch
from
12a49a5 to
8aafc9c
Compare
- Enable Export button in AppHeader - New export.js module with client-side support to assemble a .zip/.xpi static theme add-on - Add stub component for ExportThemeDialog - Add Redux store support for theme export progress and result - Extract shared convertToBrowserTheme code from add-on for producing real theme from Redux data - Add jszip and redux-promise dependencies - Turn off some eslint rules that seem annoying - Webpack config tweak for dynamic import bundle name - Add babel dynamic import plugin Issue mozilla#93
lmorchard
force-pushed
the
93-theme-export
branch
from
8aafc9c to
99cc888
Compare
Contributor
|
This works for me, really cool feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable Export button in AppHeader
New export.js module with client-side support to assemble a .zip/.xpi
static theme add-on
Add stub component for ExportThemeDialog
Add Redux store support for theme export progress and result
Extract shared convertToBrowserTheme code from add-on for producing
real theme from Redux data
Add jszip and redux-promise dependencies
Turn off some eslint rules that seem annoying
Issue #93