preventing jar files needs preventing zip files as well #171

Merged
merged 2 commits into from Oct 2, 2012

Projects

None yet

2 participants

@zalun
zalun commented Oct 2, 2012

No description provided.

@pennyfx pennyfx and 1 other commented on an outdated diff Oct 2, 2012
apps/jetpack/models.py
@@ -62,6 +65,19 @@
EDITABLE_EXTENSIONS = ("html", "css", "js", "txt", "xml", "json")
+def _raise_if_content_not_allowed(content):
+ fp = StringIO(content)
@pennyfx
pennyfx Oct 2, 2012

What does fp mean? File Pointer?

@zalun
zalun Oct 2, 2012

Yes that's a copy&paste I should be more explicit

@pennyfx pennyfx commented on an outdated diff Oct 2, 2012
apps/jetpack/errors.py
@@ -19,6 +19,9 @@ class FilenameExistException(SimpleException):
class IllegalFilenameException(SimpleException):
" This filename contains illegal characters "
+class IllegalFileException(SimpleException):
+ " This fileis not allowed "
@pennyfx
pennyfx Oct 2, 2012

typo fileis -> file is

@pennyfx
pennyfx commented Oct 2, 2012

Looks ok. r+

@pennyfx pennyfx merged commit 282b2e8 into mozilla:master Oct 2, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment