Fixes Bug 818125 #177

Merged
merged 1 commit into from Dec 11, 2012

Conversation

Projects
None yet
2 participants

zalun commented Dec 11, 2012

Add packages directory if needed (SDK 1.12 doesn't have it like older SDKs)
Allow to create empty manifests
Add SDK 1.12+ to the Builder's database
Use -i to import code
Frontend displays different data if SDK exists, but has no code
Test creation of a package with SDK 1.12
Test building with the 1.12

@zalun zalun Fixes Bug 818125
Add packages directory if needed (SDK 1.12 doesn't have it like older SDKs)
Allow to create empty manifests
Add SDK 1.12+ to the Builder's database
Use -i to import code
Frontend displays different data if SDK exists, but has no code
Test creation of a package with SDK 1.12
Test building with the 1.12
267a41c

zalun commented Dec 11, 2012

Just one comment - XPI's are not working on my local machine, but these aren't working for older SDKs as well.
I need to reinstall this system as soon as this bug gets fixed (real mess in libraries, /me loves gentoo, but time is always an issue).

@seanmonstar seanmonstar commented on the diff Dec 11, 2012

apps/jetpack/management/__init__.py
@@ -253,7 +262,7 @@ def update_SDK(sdk_dir_name, options=None, version=None):
)
-def create_SDK(sdk_dir_name, options=None, version=None):
+def create_SDK(sdk_dir_name, options=None, version=None, should_import=None):
@seanmonstar

seanmonstar Dec 11, 2012

Member

nitpick, this is a boolean value, default should be False

@seanmonstar seanmonstar added a commit that referenced this pull request Dec 11, 2012

@seanmonstar seanmonstar Merge pull request #177 from zalun/bug_818125-add_sdk_1.12
Fixes Bug 818125
e242946

@seanmonstar seanmonstar merged commit e242946 into mozilla:master Dec 11, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment