Update some FlightDeck tests to use the current SDK version, not SDK 1.12 #189

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@KWierso
Mozilla member

According to Jenkins, 10 tests started failing back when SDK 1.13 was added to FlightDeck. Those tests seem to explicitly test SDK 1.12.

Having not run these tests myself, I'd assume we should at least be testing the now-current SDK version (1.14 at the moment), if not somehow always test the latest SDK version automatically.

This pull request changes two tests that were using 1.12 so they now use 1.14.

@KWierso
Mozilla member

@zalun You added these tests back when 1.12 shipped because 1.12 was different than earlier SDKs. Do we still need them at all? Should they be updated like this (or some other way)?

@seanmonstar
Mozilla member

Wouldn't the TEST_SDK value in settings.py or settings_local.py be the better place?

@KWierso KWierso Use settings.TEST_SDK instead in place of explicit version numbers in…
… some tests that have been failing since SDK 1.13 was added to FlightDeck
ac22138
@KWierso
Mozilla member

True. How about this?

@seanmonstar
Mozilla member

probably, but I don't know what these tests are for. i'll let @zalun merge.

@KWierso KWierso closed this Jun 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment