Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Update some FlightDeck tests to use the current SDK version, not SDK 1.12 #189

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Member

KWierso commented Mar 28, 2013

According to Jenkins, 10 tests started failing back when SDK 1.13 was added to FlightDeck. Those tests seem to explicitly test SDK 1.12.

Having not run these tests myself, I'd assume we should at least be testing the now-current SDK version (1.14 at the moment), if not somehow always test the latest SDK version automatically.

This pull request changes two tests that were using 1.12 so they now use 1.14.

Member

KWierso commented Mar 28, 2013

@zalun You added these tests back when 1.12 shipped because 1.12 was different than earlier SDKs. Do we still need them at all? Should they be updated like this (or some other way)?

Member

seanmonstar commented Mar 28, 2013

Wouldn't the TEST_SDK value in settings.py or settings_local.py be the better place?

Use settings.TEST_SDK instead in place of explicit version numbers in…
… some tests that have been failing since SDK 1.13 was added to FlightDeck
Member

KWierso commented Mar 28, 2013

True. How about this?

Member

seanmonstar commented Mar 29, 2013

probably, but I don't know what these tests are for. i'll let @zalun merge.

@KWierso KWierso closed this Jun 17, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment