Make responses more stable #25

almet opened this Issue Dec 17, 2012 · 1 comment


None yet

3 participants

almet commented Dec 17, 2012

I have been using this client to automate some work I want to do with marketplace, but I'm a bit surprised to have requests objects in response of my function calls.

For instance, the requests library changed recently and when I want to have a json version of the request, I need to do response.json() rather than response.json previously.

My point is that things can break easily on thelibrary we use and that we probably shouldn't expose this on the users of our library.

For instance, I would prefer to have the results of the APIs returned directly (as a python dict), and to have exceptions from this library if we don't have the behaviour we want on the server.

What do you think? I would be happy to help you work on the APIs we would like to have for this library.

fwenzel commented Dec 17, 2012

I agree with Alexis: I think the library should hide "fairly well" that you are talking to a server in the background.

@zalun zalun was assigned Dec 18, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment