No description provided.
add mimetype and check for position
Merge branch 'master' of github.com:mozilla/MarketplaceClientExample
directory layout changed
* example app moved
* lib renamed to marketplace
* tests moved inside marketplace
* Marketplace is split into Client and Connection classes
setup tools added to setup.py to provide requirements
no apps package anymore
This doesn't require nose, but the https://github.com/zalun/Marketplace.Python/tree/creating_package mentions a nose test command. Should probably add a note about how to install nose.
Indeed - an info in documentation
tearDown is called at the end of every test, so this means at the end of every test the requests are reset to normal... is there a need to do this?
I think it's a good practice to start every test with the same basis. Otherwise one may receive an answer from request defined in another test
nice use of Mock
maybe add a note in the documentation that mock is needed (but won't be installed in setup.py)
Sure - same as with the nose - it isn't needed for package to be used, but needed for tests
extra new lines on the end
two lines before classes, one before method (see line 42)
Should we put a raise NotImplementedError here?
Yes, you're right
Is this still relevant?
IMHO yes - it contains one line - marketplace, but it's a good practice to keep requirements in the file
Looking good zalun, it seemed to install just fine using setup.py here. Yay!
raise notimplemented added
removed consumer dependency injection
some simple pylint fixes
docstrings and stuff
three_legged removed from __init__
urls as a static
not used mimetype keyword removed
fixed fetch for screenshot methods
info about additional packages needed for testing purposes