Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Creating package #18

Merged
merged 12 commits into from almost 2 years ago

2 participants

Piotr Zalewa Andy McKay
Piotr Zalewa
Collaborator

No description provided.

zalun added some commits
Piotr Zalewa zalun add mimetype and check for position 095f5af
Piotr Zalewa zalun Merge branch 'master' of github.com:mozilla/MarketplaceClientExample
Conflicts:
	python/lib/marketplace.py
b6f0bbc
Piotr Zalewa zalun license added
directory layout changed
 * example app moved
 * lib renamed to marketplace
 * tests moved inside marketplace

classes modified
 * Marketplace is split into Client and Connection classes

setup tools added to setup.py to provide requirements
3e6d3ce
Piotr Zalewa zalun no apps package anymore fdf4759
Andy McKay

This doesn't require nose, but the https://github.com/zalun/Marketplace.Python/tree/creating_package mentions a nose test command. Should probably add a note about how to install nose.

Collaborator

Indeed - an info in documentation

Andy McKay

tearDown is called at the end of every test, so this means at the end of every test the requests are reset to normal... is there a need to do this?

Collaborator

I think it's a good practice to start every test with the same basis. Otherwise one may receive an answer from request defined in another test

Andy McKay
Owner

maybe add a note in the documentation that mock is needed (but won't be installed in setup.py)

Collaborator

Sure - same as with the nose - it isn't needed for package to be used, but needed for tests

Andy McKay

extra new lines on the end

Andy McKay

two lines before classes, one before method (see line 42)

Andy McKay

Should we put a raise NotImplementedError here?

Collaborator

Yes, you're right

Andy McKay

Is this still relevant?

Collaborator

IMHO yes - it contains one line - marketplace, but it's a good practice to keep requirements in the file

Andy McKay
Owner

Looking good zalun, it seemed to install just fine using setup.py here. Yay!

Collaborator

:D

Piotr Zalewa zalun merged commit 44ecb3e into from
Piotr Zalewa zalun closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 12 unique commits by 1 author.

Jul 05, 2012
Piotr Zalewa zalun add mimetype and check for position 095f5af
Sep 25, 2012
Piotr Zalewa zalun Merge branch 'master' of github.com:mozilla/MarketplaceClientExample
Conflicts:
	python/lib/marketplace.py
b6f0bbc
Oct 05, 2012
Piotr Zalewa zalun license added
directory layout changed
 * example app moved
 * lib renamed to marketplace
 * tests moved inside marketplace

classes modified
 * Marketplace is split into Client and Connection classes

setup tools added to setup.py to provide requirements
3e6d3ce
Piotr Zalewa zalun no apps package anymore fdf4759
Oct 08, 2012
Piotr Zalewa zalun raise notimplemented added 7dfddb0
Piotr Zalewa zalun removed consumer dependency injection
some simple pylint fixes
42ae14e
Piotr Zalewa zalun docstrings and stuff 58fdf42
Piotr Zalewa zalun three_legged removed from __init__
urls as a static
4c36ff5
Piotr Zalewa zalun not used mimetype keyword removed 0f8f42d
Piotr Zalewa zalun fixed fetch for screenshot methods 9cc4049
Piotr Zalewa zalun pylint fixes ea3da86
Piotr Zalewa zalun info about additional packages needed for testing purposes ae2bfba
Something went wrong with that request. Please try again.