Skip to content

Creating package #18

Merged
merged 12 commits into from Oct 8, 2012

2 participants

@zalun
zalun commented Oct 5, 2012

No description provided.

zalun added some commits Jul 5, 2012
@zalun zalun add mimetype and check for position 095f5af
@zalun zalun Merge branch 'master' of github.com:mozilla/MarketplaceClientExample
Conflicts:
	python/lib/marketplace.py
b6f0bbc
@zalun zalun license added
directory layout changed
 * example app moved
 * lib renamed to marketplace
 * tests moved inside marketplace

classes modified
 * Marketplace is split into Client and Connection classes

setup tools added to setup.py to provide requirements
3e6d3ce
@zalun zalun no apps package anymore fdf4759
@andymckay
Mozilla member

This doesn't require nose, but the https://github.com/zalun/Marketplace.Python/tree/creating_package mentions a nose test command. Should probably add a note about how to install nose.

zalun replied Oct 6, 2012

Indeed - an info in documentation

@andymckay

tearDown is called at the end of every test, so this means at the end of every test the requests are reset to normal... is there a need to do this?

zalun replied Oct 6, 2012

I think it's a good practice to start every test with the same basis. Otherwise one may receive an answer from request defined in another test

@andymckay

nice use of Mock

Mozilla member

maybe add a note in the documentation that mock is needed (but won't be installed in setup.py)

zalun replied Oct 6, 2012

Sure - same as with the nose - it isn't needed for package to be used, but needed for tests

@andymckay

extra new lines on the end

@andymckay
Mozilla member

two lines before classes, one before method (see line 42)

@andymckay
Mozilla member

Should we put a raise NotImplementedError here?

zalun replied Oct 6, 2012

Yes, you're right

@andymckay
Mozilla member

Is this still relevant?

zalun replied Oct 6, 2012

IMHO yes - it contains one line - marketplace, but it's a good practice to keep requirements in the file

@andymckay
Mozilla member

Looking good zalun, it seemed to install just fine using setup.py here. Yay!

zalun replied Oct 6, 2012

:D

@zalun zalun merged commit 44ecb3e into mozilla:master Oct 8, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.