Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace timer with threads #1064

Merged
merged 6 commits into from Feb 28, 2019

Conversation

Projects
None yet
2 participants
@pwnbus
Copy link
Collaborator

pwnbus commented Jan 23, 2019

#1018 should be merged first, as it creates version 1.0.3 of mozdef_util (this PR sets it to version 1.0.4)

pwnbus added some commits Jan 23, 2019

@pwnbus pwnbus added this to the Release v1.36 milestone Jan 23, 2019

pwnbus added some commits Jan 30, 2019

@pwnbus pwnbus modified the milestones: Release v1.36, Release v1.37 Feb 1, 2019

@pwnbus pwnbus requested a review from arcrose Feb 6, 2019

@arcrose
Copy link
Member

arcrose left a comment

It seems like it would be a little bit overkill right now, but this code allows for a potential race condition.
As an example, the flush method in bulk_queue.py performs a mutating operation through self.es_client. This should be protected by a Lock so that changes in the future can expect for read & write access to be safe by default.

@pwnbus pwnbus merged commit e9566f6 into master Feb 28, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pwnbus pwnbus deleted the replace_timer_with_threads branch Feb 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.