Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding open and close abstraction for managing indexes #1106

Merged
merged 17 commits into from Apr 10, 2019

Conversation

Projects
None yet
2 participants
@Phrozyn
Copy link
Contributor

commented Feb 15, 2019

No description provided.

Phrozyn added some commits Feb 15, 2019

@pwnbus pwnbus added this to the Release v1.37 milestone Feb 19, 2019

Show resolved Hide resolved cron/closeIndices.py Outdated
Show resolved Hide resolved cron/closeIndices.py Outdated
Show resolved Hide resolved cron/closeIndices.py Outdated
Show resolved Hide resolved cron/closeIndices.py Outdated
Show resolved Hide resolved cron/closeIndices.py Outdated
Show resolved Hide resolved cron/closeIndices.py Outdated
Show resolved Hide resolved mozdef_util/mozdef_util/elasticsearch_client.py Outdated
Show resolved Hide resolved mozdef_util/mozdef_util/elasticsearch_client.py Outdated
Show resolved Hide resolved tests/mozdef_util/test_elasticsearch_client.py Outdated
Show resolved Hide resolved tests/mozdef_util/test_elasticsearch_client.py Outdated

@pwnbus pwnbus modified the milestones: Release v1.37, Release v1.38 Feb 28, 2019

@Phrozyn Phrozyn requested a review from pwnbus Mar 12, 2019

Phrozyn added some commits Mar 12, 2019

Including requested changes, be more specific about what we want to c…
…lose. Change method in which we determine if the index should be closed.

Needs a fresh review after code changes.

@pwnbus
Copy link
Collaborator

left a comment

A couple blockers that affect the execution of the cron script.

Show resolved Hide resolved cron/closeIndices.py Outdated
Show resolved Hide resolved cron/closeIndices.py Outdated
Show resolved Hide resolved tests/mozdef_util/test_elasticsearch_client.py Outdated
Correcting month_ago_date logic, removing quotes form default index_a…
…ge, correcting method call name, correcting function name in esclient
@Phrozyn

This comment has been minimized.

Copy link
Contributor Author

commented Mar 27, 2019

This was tested to work in my dev environment, all requested changes have been implemented.

@Phrozyn Phrozyn requested a review from pwnbus Mar 27, 2019

@pwnbus pwnbus modified the milestones: Release v1.38, Release v1.39 Mar 28, 2019

Phrozyn added some commits Apr 5, 2019

Show resolved Hide resolved CHANGELOG Outdated
@pwnbus

pwnbus approved these changes Apr 9, 2019

@Phrozyn Phrozyn merged commit 5cefe7c into master Apr 10, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Phrozyn Phrozyn deleted the add_index_open_and_close_abstraction branch Apr 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.