Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust proxy alerts #1112

Merged
merged 7 commits into from Feb 28, 2019

Conversation

Projects
None yet
2 participants
@mpurzynski
Copy link
Contributor

mpurzynski commented Feb 26, 2019

No description provided.

Michal Purzynski added some commits Feb 21, 2019

@@ -31,36 +30,39 @@ class TestAlertProxyDropExecutable(AlertTestSuite):
# This event is the default negative event that will not cause the
# alert to trigger
default_negative_event = AlertTestSuite.copy(default_event)
default_negative_event["_source"]["details"]["destination"] = "http://foo.mozilla.com/index.html"
default_negative_event["_source"]["details"][

This comment has been minimized.

@pwnbus

pwnbus Feb 26, 2019

Collaborator

I think this change actually makes it more difficult to read. Since I'm assuming these changes were automatically done via some tool, can you configure that tool to ignore line length edits like these in the future please?

This comment has been minimized.

@mpurzynski

mpurzynski Feb 26, 2019

Author Contributor

https://github.com/ambv/black is what I started using for everything. Do you want me to stop splitting lines and rather keep them long? I guess I can configure that https://black.readthedocs.io/en/stable/the_black_code_style.html#how-black-wraps-lines

@pwnbus pwnbus added this to the Release v1.38 milestone Feb 28, 2019

@pwnbus

pwnbus approved these changes Feb 28, 2019

@pwnbus pwnbus merged commit f0c45c2 into mozilla:master Feb 28, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mpurzynski mpurzynski deleted the mpurzynski:adjust_proxy_alerts branch Mar 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.