Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change CI/CD sequence for v1.38.5 #1214

Merged
merged 3 commits into from Apr 10, 2019

Conversation

Projects
None yet
2 participants
@gene1wood
Copy link
Member

gene1wood commented Apr 10, 2019

Changed the CI/CD order to now build docker images in CodeBuild, upload them
to DockerHub and then pull them down in the packer instance. Updated docs.

I confirmed this one works in a branch and built a new stack and updated an existing stack with the resulting artifacts.

gene1wood added some commits Apr 9, 2019

@gene1wood gene1wood requested a review from pwnbus Apr 10, 2019

@@ -46,7 +46,8 @@ RUN mkdir -p /opt/mozdef/envs/meteor/mozdef
RUN if [ "${METEOR_BUILD}" = "YES" ]; then \
cd /opt/mozdef/envs/mozdef/meteor && \
meteor npm install && \
meteor build --server localhost:3002 --directory /opt/mozdef/envs/meteor/mozdef && \
echo "Starting meteor build" && \
time meteor build --server localhost:3002 --directory /opt/mozdef/envs/meteor/mozdef && \

This comment has been minimized.

Copy link
@pwnbus

pwnbus Apr 10, 2019

Collaborator

Do we still want to include this time command? Or was this for debugging purposes?

This comment has been minimized.

Copy link
@gene1wood

gene1wood Apr 10, 2019

Author Member

I'd hoped to include it as it's useful information during the build to show what just happened for the last 3 minutes. I looked into how to get meteor build to output some kind of progress our output and had no luck. So yes, I think we should keep the time in. Is there any downside?

This comment has been minimized.

Copy link
@pwnbus

pwnbus Apr 10, 2019

Collaborator

I'm fine with keeping it in, just curious if it was intentional or not.

@pwnbus

pwnbus approved these changes Apr 10, 2019

@pwnbus pwnbus merged commit 33a770b into mozilla:master Apr 10, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gene1wood gene1wood deleted the gene1wood:change-cicd-sequence branch Apr 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.