Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate version of files in cloudymozdef build #1464

Merged
merged 2 commits into from Oct 17, 2019

Conversation

@pwnbus
Copy link
Collaborator

pwnbus commented Sep 24, 2019

No description provided.

@pwnbus

This comment has been minimized.

Copy link
Collaborator Author

pwnbus commented Sep 24, 2019

@andrewkrug Since during setup, we copy the files into the build directory, I don't think we want to have them version controlled (as they are in the repo in other files). Thoughts? I think this will require updating the Makefile as well, but wanted to get your feedback first.

@andrewkrug

This comment has been minimized.

Copy link
Contributor

andrewkrug commented Oct 17, 2019

Does the make target still work?

@pwnbus pwnbus force-pushed the remove_cloudymozdef_build_files branch from 59bc921 to 3799ca0 Oct 17, 2019
@pwnbus

This comment has been minimized.

Copy link
Collaborator Author

pwnbus commented Oct 17, 2019

@pwnbus pwnbus merged commit 7027ce0 into master Oct 17, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@pwnbus pwnbus deleted the remove_cloudymozdef_build_files branch Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.