New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report an atomicity issue #1718

Closed
baigd opened this Issue Sep 14, 2015 · 1 comment

Comments

Projects
None yet
2 participants
@baigd

baigd commented Sep 14, 2015

Hi, Developers of MozStumbler,

I am writing to report an atomicity issue. I would very appreciate if you could check below for details and confirm with us whether it is a real problem.

File: mozilla/MozStumbler/android/src/main/java/org/mozilla/osmdroid/tileprovider/util/CloudmadeUtil.java
Location: Line 128
Description:
Data race may manifest if thread_1 happen to set mToken.length==0 in 128, which assign "mToken" a new memory address, then thread_2 and thread_3 synch on the new "mToken" address, which is different from what thread_1 is locked on. They may simultaneously modify mToken.

@crankycoder

This comment has been minimized.

Show comment
Hide comment
@crankycoder

crankycoder Sep 21, 2015

Contributor

It's possible that the CloudMade code is broken. That code branch is actually a form of osmdroid. We've deleted all the CloudMade related code (CloudMadeTileSource, HttpClientFactory, etc) on Aug 28th.

050eeda

None of this is obvious though as we've been swamped and haven't cut a new release in far too long. I really need to get on that.

Contributor

crankycoder commented Sep 21, 2015

It's possible that the CloudMade code is broken. That code branch is actually a form of osmdroid. We've deleted all the CloudMade related code (CloudMadeTileSource, HttpClientFactory, etc) on Aug 28th.

050eeda

None of this is obvious though as we've been swamped and haven't cut a new release in far too long. I really need to get on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment