Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

OneMozilla theme is not fully localizable #2

Open
tomer opened this Issue May 24, 2012 · 4 comments

Comments

Projects
None yet
2 participants

tomer commented May 24, 2012

I've installed the theme on Hebrew WordPress. While most of the strings appear to be localized, I've found some hardcoded strings (for example here: https://github.com/mozilla/One-Mozilla-blog/blob/master/themes/OneMozilla/comments.php#L26), and other places that require us to set a gettext domain named onemozilla, while these strings could be fetched from the default branch (so we won't need to translate it at all if the core WordPress is already localized).

Contributor

MikkCZ commented Jan 27, 2015

Currently I am playing with the One-Mozilla theme, so I can look at it and fix if it's the desired behavior.

Contributor

MikkCZ commented Feb 18, 2015

The missing domain has been fixed in e868bbe. But still there is the issue with missing translation for number of comment responses in #22.

As for the strings in WordPress, I've found quite a lot of them in wordpress.pot (sometimes with different upper/lower case), so removing them from OneMozilla may take longer.

Contributor

MikkCZ commented Mar 19, 2015

After #22, I think there won't be any string with missing domain or not in the .pot file.

@craigcook Do you think it's better to reuse strings localized in WordPress itself, or not to rely on WP (in case the WordPress locale someone would like to have is missing or any string the theme uses gets deleted over time)?

Contributor

MikkCZ commented Apr 2, 2017

I went through the template and haven't found any string, that are not localizable. @tomer do you have any in mind? If not, let's close this until we find new hardcoded strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment