Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructuring the repo #246

Merged
merged 9 commits into from
Oct 26, 2019
Merged

Restructuring the repo #246

merged 9 commits into from
Oct 26, 2019

Conversation

kindavishal
Copy link
Collaborator

Solves #245

@kindavishal
Copy link
Collaborator Author

kindavishal commented Oct 21, 2019

Hey @elioqoshi @pransh15 @AnXh3L0 @irvin @yofiesetiawan 👋 have a look here 👀
Tried some housekeeping 💯 the repo should look more manageable and easily accessible now! ✨

@kindavishal
Copy link
Collaborator Author

kindavishal commented Oct 21, 2019

What's new in this?

  • Product/Project wise assets now lie in their own respective folders;
    e.g. /Firefox, /A-Frame /Rust and so on
  • All the Communities, i.e. their logos, banners, etc. now go under /Mozillians/Communities folder
  • Campaigns run by Mozillians now have their own folders under /Campaigns
  • The year wise sorting still remains under Community Activites/<year> only for those assets which have date, venue, etc. on them. However, I considered campaigns such as "Rain of Rust", "Privacy Month" to NOT be region specific, which is why they go under /Campaigns. Which in other words means that the year wise folders now only consists of smaller events/meetups run by various communities.
  • There's a /Other Icons folder which consists of smaller yet may-be-useful logos that are relatable to Firefox and Mozilla.
    e.g. The Tracking Protection icon, Web Developers Icons, etc.

While doing this, I found out quite a lot of assets which are available only in a single language, e.g. Spanish. I propose that we open Hackotoberfest Issues for new contributors to localize those graphics!

@irvin
Copy link
Contributor

irvin commented Oct 21, 2019

Seems good for me.

@irvin
Copy link
Contributor

irvin commented Oct 21, 2019

Seens good for me.

@kindavishal kindavishal changed the title Re-structure of repo Restructuring the repo Oct 23, 2019
@yofiesetiawan
Copy link
Contributor

Looks good, thank you Vishal!

@kindavishal
Copy link
Collaborator Author

Thank you for your feedback everyone! Merging this ✨

@kindavishal kindavishal merged commit cd78c2f into mozilla:master Oct 26, 2019
@pransh15
Copy link
Collaborator

This looks good, definitely gives us a clearer path to the assets and how well are they're placed. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants