Skip to content
This repository was archived by the owner on Jan 31, 2018. It is now read-only.

Commit 83aecb5

Browse files
committed
Merge pull request #30 from pmclanahan/master
Add keyboard support to buttons. Move images to a single sprites image. Fix bug 747532 747963.
2 parents 77b7f65 + c522d8b commit 83aecb5

10 files changed

Lines changed: 78 additions & 96 deletions

File tree

media/img/sprite.png

483 Bytes
Loading

media/img/sprite.psd

28.5 KB
Binary file not shown.

media/img/sprites.png

-797 Bytes
Binary file not shown.

media/socialshare.min.css

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

media/socialshare.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/img/sprite.png

483 Bytes
Loading

src/img/sprite.psd

28.5 KB
Binary file not shown.

src/img/sprites.png

-797 Bytes
Binary file not shown.

src/socialshare.js

Lines changed: 22 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -6,24 +6,19 @@
66

77
var toggle = '[data-toggle="socialshare"]';
88
var share_selector = '.socialshare';
9-
var fb_iframe = '.socialshare.open[data-type="small-bubbles"] .share-options div.fb-like iframe';
9+
var fb_iframe = '.socialshare.open[data-type="small-bubbles"] #share-options div.fb-like iframe';
1010
var $share_container;
1111
var packaged_html = '' +
1212
'<div class="dropdown-toggle" data-toggle="socialshare">' +
13-
' <div class="share-link"><div>' +
14-
' <div class="heart"></div>' +
15-
' <p class="text">Share This</p>' +
16-
' <div class="caret"><div></div></div></div>' +
17-
' </div><div class="clear">' +
18-
'</div>' +
19-
'<div class="share-options">' +
20-
' <ul>' +
21-
' <li><div class="fb-like"></div></li>' +
22-
' <li><div class="g-plusone"></div></li>' +
23-
' <li><a href="https://twitter.com/share" class="twitter-share-button"></a></li>' +
24-
' </ul>' +
25-
'</div>' +
26-
'<div id="fb-root"></div>';
13+
' <a class="share-button" role="button" href="#share-options" aria-controls="share-options" aria-expanded="false"><span>Share This</span></a>' +
14+
' <div id="share-options">' +
15+
' <ul>' +
16+
' <li><div class="fb-like"></div></li>' +
17+
' <li><div class="g-plusone"></div></li>' +
18+
' <li><a href="https://twitter.com/share" class="twitter-share-button"></a></li>' +
19+
' </ul>' +
20+
' </div>' +
21+
'</div>';
2722
var type;
2823
var providers = {
2924
facebook: {
@@ -85,6 +80,7 @@
8580

8681
var clear_menus = function() {
8782
$(toggle).parent().removeClass('open');
83+
$(toggle).find(".share-button").attr("aria-expanded","false");
8884
};
8985

9086
var Dropdown = function(element) {
@@ -104,6 +100,7 @@
104100

105101
clear_menus();
106102
if (!isActive) {
103+
$(this).find(".share-button").attr("aria-expanded","true");
107104
$parent.toggleClass('open');
108105
}
109106
$share_container = $(fb_iframe).css('width',
@@ -115,6 +112,7 @@
115112
},
116113
load_sharing: function() {
117114
if (!this.scripts_loaded) {
115+
$('body').append('<div id="fb-root" aria-hidden="true"></div>');
118116
for (var key in providers) {
119117
this.load_script(providers[key].src, providers[key].id);
120118
}
@@ -177,11 +175,16 @@
177175
$share_container.find(providers[key].selector)
178176
.attr(providers[key][$share_container.attr('data-type')]);
179177
}
180-
181-
$(document).keypress(function(e) {
182-
if (e.which === 0 && $share_container.hasClass('open')) {
183-
clear_menus();
178+
$share_container.find(".share-button").keypress(function(e) {
179+
if (e.which === 32) {
180+
$(this).trigger("click");
181+
e.preventDefault();
184182
}
185183
});
184+
$(document).keydown(function(e) {
185+
if (e.which === 27 && $(".socialshare").hasClass("open")) {
186+
$(".share-button").trigger("click");
187+
}
188+
});
186189
});
187190
})(window.jQuery);

0 commit comments

Comments
 (0)