Skip to content
Browse files

Merge pull request #122 from zacc/fix_get_base

Fix get url
  • Loading branch information...
2 parents b7dc91a + ebe7c0c commit a96bb11d0ca2d696d2a8c534b0ffec8a5b4df26d @stephendonner stephendonner committed
Showing with 5 additions and 8 deletions.
  1. +0 −3 pages/base.py
  2. +3 −3 tests/test_layout.py
  3. +2 −2 tests/test_smoke_tests.py
View
3 pages/base.py
@@ -26,9 +26,6 @@ def page_title(self):
def page_heading(self):
return self.selenium.find_element(*self._page_heading).text
- def get_url_path(self, path):
- self.selenium.get(self.base_url + path)
-
def click_server_status(self):
self.selenium.find_element(*self._server_status_locator).click()
from pages.crash_stats_page import CrashStatsStatus
View
6 tests/test_layout.py
@@ -29,17 +29,17 @@ def test_that_product_versions_are_ordered_correctly(self, mozwebqa):
def test_that_topcrasher_is_not_returning_http500(self, mozwebqa):
csp = CrashStatsHomePage(mozwebqa)
- csp.get_url_path(csp.base_url + '/topcrasher')
+ csp.selenium.get(mozwebqa.base_url + '/topcrasher')
tc = CrashStatsTopCrashers(mozwebqa)
Assert.contains('Top Crashers', tc.page_heading)
Assert.true(tc.results_found, 'No results found!')
def test_that_report_is_not_returning_http500(self, mozwebqa):
csp = CrashStatsHomePage(mozwebqa)
- csp.get_url_path(csp.base_url + '/report')
+ csp.selenium.get(mozwebqa.base_url + '/report')
Assert.contains('Page not Found', csp.page_heading)
def test_that_correlation_is_not_returning_http500(self, mozwebqa):
csp = CrashStatsHomePage(mozwebqa)
- csp.get_url_path(csp.base_url + '/correlation')
+ csp.selenium.get(mozwebqa.base_url + '/correlation')
Assert.contains('Page not Found', csp.page_heading)
View
4 tests/test_smoke_tests.py
@@ -65,6 +65,6 @@ def test_that_bugzilla_link_contain_current_site(self, mozwebqa):
Bug 631737
"""
csp = CrashStatsHomePage(mozwebqa)
- path = '/invaliddomain'
- csp.get_url_path(path)
+ path = '/invalidpath'
+ csp.selenium.get(mozwebqa.base_url + path)
Assert.contains('bug_file_loc=%s%s' % (mozwebqa.base_url, path), urllib.unquote(csp.link_to_bugzilla))

0 comments on commit a96bb11

Please sign in to comment.
Something went wrong with that request. Please try again.