Skip to content
This repository has been archived by the owner on Feb 29, 2020. It is now read-only.

Lin32 opt Perma-red: sessionstore/browser_window{Restore_perwindowpb,StateContainer}.js CRASH [@ RunWatchdog] #2805

Closed
Mardak opened this issue Jun 29, 2017 · 11 comments

Comments

@Mardak
Copy link
Member

Mardak commented Jun 29, 2017

This looks to have been happening for a little bit only on "Linux opt" for a couple tests:

 LOG ERROR | TEST-UNEXPECTED-FAIL | browser/components/sessionstore/test/browser_windowRestore_perwindowpb.js | application terminated with exit code 11 [log…] 
 LOG ERROR | TEST-UNEXPECTED-FAIL | browser/components/sessionstore/test/browser_windowStateContainer.js | application terminated with exit code 11 [log…] 

Restore_perwindowpb: https://treeherder.mozilla.org/logviewer.html#?job_id=110250146&repo=pine&lineNumber=3504
StateContainer: https://treeherder.mozilla.org/logviewer.html#?job_id=108959559&repo=pine&lineNumber=3039

Might be related to the filed intermittent bugs:
https://bugzilla.mozilla.org/show_bug.cgi?id=1244904
https://bugzilla.mozilla.org/show_bug.cgi?id=1361528

@Mardak Mardak added this to the City of God (July 9) milestone Jun 29, 2017
@Mardak Mardak changed the title Lin32 opt Perma-Red: sessionstore/browser_window{Restore_perwindowpb,StateContainer}.js CRASH [@ RunWatchdog] Lin32 opt Perma-red: sessionstore/browser_window{Restore_perwindowpb,StateContainer}.js CRASH [@ RunWatchdog] Jun 29, 2017
@Mardak Mardak added this to Crashes in Pref-on Test Failures Jun 30, 2017
@Mardak
Copy link
Member Author

Mardak commented Jul 3, 2017

The StateContainer blamed crash was recently turned off for debug builds: https://bugzilla.mozilla.org/show_bug.cgi?id=1373116

@sarracini
Copy link
Contributor

@Mardak try and see if this can be caught by running it multiple times

@piatra piatra self-assigned this Jul 5, 2017
@Mardak
Copy link
Member Author

Mardak commented Jul 5, 2017

I tried running the whole sessionstore directory with repeat but didn't get it to crash. I suppose it's because my VM is "Ubuntu; Linux x86_64" so not quite the Linux32 opt. And the pine runs do seem to only crash on 32bit not 64.

@piatra
Copy link
Contributor

piatra commented Jul 6, 2017

@Mardak Same failures on mozilla-central with activity-stream turned off in profile.js see here Shouldn't this be enough to ignore this failure?

@Mardak
Copy link
Member Author

Mardak commented Jul 6, 2017

It is indeed quite frequent per the reports in https://bugzilla.mozilla.org/show_bug.cgi?id=1244904 ranging up to 0.4 failures per push (and as of 3 days ago "This is the # 1 most frequent failure this week."). However on pine, this test seems to be failing on 100% of pushes, hence the perma-orange label. If we tried to turn on with 100% consistent test failure, the commit would be backed out.

On the other hand, because the failure rate is so high, it seems likely that something will be done on the mozilla-central side to address the intermittents. The usual steps are to turn off the test, except as described in various related RunWatchdog intermittent test failure bugs, the blamed test is not too accurate, so there will need to be some more work done to "fix" things.

@piatra
Copy link
Contributor

piatra commented Jul 6, 2017

@Mardak thank you for explaining, it makes more sense now. I tried a try run just on linux32 with latest AS but with the pref turned off and I still get the same failures.
Even though we might influence the test with AS turned on these bugs are getting a lot of attention I would put off doing something about them because they have high priority and might get fixed/changed/disabled soon.

@Mardak
Copy link
Member Author

Mardak commented Jul 13, 2017

I'm currently looking at finding a set of tests that can be disabled. The set of 20 that gbrown found is not sufficient when activity-stream is enabled.

https://bugzilla.mozilla.org/show_bug.cgi?id=1244904#c7

@piatra
Copy link
Contributor

piatra commented Jul 14, 2017

There's now a patch in bugzilla to disable the tests and it has r+.

https://hg.mozilla.org/integration/mozilla-inbound/rev/82f7afb4f46b

@Mardak Mardak closed this as completed Jul 15, 2017
@Mardak Mardak moved this from Crashes to Done in Pref-on Test Failures Jul 15, 2017
@piatra
Copy link
Contributor

piatra commented Jul 17, 2017

It looks like this bug is making a comeback? https://bugzilla.mozilla.org/show_bug.cgi?id=1244904#c51 independent of activity stream. If I'm wrong please disregard and close again.

@piatra piatra reopened this Jul 17, 2017
@Mardak
Copy link
Member Author

Mardak commented Jul 17, 2017

That comment is the summary of the last 7 days, and the patch only landed 3 days ago. And the graph's uptick is from try pushes that were based on commits older than 3 days ago.

@Mardak Mardak closed this as completed Jul 17, 2017
@Mardak Mardak moved this from Assigned / Milestone 1 to Complete in Land in Nightly / Graduate Jul 24, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Development

No branches or pull requests

6 participants