Skip to content
This repository has been archived by the owner. It is now read-only.

/ activity-stream Archived

feat (topsites): #2525 implement edit top site feature #2595

Merged
merged 1 commit into from May 15, 2017
Merged

feat (topsites): #2525 implement edit top site feature #2595

merged 1 commit into from May 15, 2017

Conversation

@rlr
Copy link
Contributor

@rlr rlr commented May 15, 2017

I still need to add the user event pings for both add and edit. I'll do it as a followup because this is big enough as it is.

r? @ncloudioj

Fixes #2525
@rlr
feat (topsites): #2525 implement edit top site feature
3823007
@coveralls
Copy link

@coveralls coveralls commented May 15, 2017

Coverage Status

Coverage increased (+0.002%) to 88.667% when pulling 3823007 on rlr:gh2525/topsite-edit into 05e1eb3 on mozilla:master.
@ncloudioj ncloudioj self-requested a review May 15, 2017
@ncloudioj
ncloudioj approved these changes May 15, 2017
View changes
Copy link
Member

@ncloudioj ncloudioj left a comment

R+! I like those tests 🎱
@ncloudioj ncloudioj assigned rlr and unassigned ncloudioj May 15, 2017
@rlr rlr merged commit c27e583 into mozilla:master May 15, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.002%) to 88.667%
Details
@rlr rlr deleted the rlr:gh2525/topsite-edit branch May 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ncloudioj ncloudioj

Assignees

@rlr rlr

Labels
PR / R+ pushed-to-pine
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@rlr @coveralls @ncloudioj @dmose