This repository has been archived by the owner. It is now read-only.
feat(topsites): Set Top Site card image source to high-res icon when available #3395
Conversation
|
The m-c change to provide favicon size has landed, and even without nan's fetch high resolution icons, some sites already put a large icon as their usual favicon ( Before: After: So this PR seems like it can be reviewed now. (Looks like we want to set a background when using icons in case they're transparent. Or maybe hide the letter fallback.) |
| @@ -129,7 +129,7 @@ | |||
| } | |||
| } | |||
|
|
|||
| .tippy-top-icon { | |||
| .rich-icon { | |||
| position: absolute; | |||
Mardak
Sep 10, 2017
Member
Might be okay to just put a background-color: white here?
Or use $background-primary (grey-10 #f9f9fa):
As long as it hides the fallback ;)
Might be okay to just put a background-color: white here?
Or use $background-primary (grey-10 #f9f9fa):
As long as it hides the fallback ;)
aaronrbenson
Sep 11, 2017
Collaborator
I lean towards the grey-10 option here just in case there's a white icon. It's not perfect but at least you could make out that something is there.
I lean towards the grey-10 option here just in case there's a white icon. It's not perfect but at least you could make out that something is there.
|
R+ one comment |
| let imageClassName; | ||
| let imageStyle; | ||
| if (tippyTopIcon) { | ||
| imageClassName = "tippy-top-icon"; | ||
| if (tippyTopIcon || faviconSize >= 96) { |
k88hudson
Sep 11, 2017
Member
Maybe make this a constant like MIN_FAVICON_SIZE
Maybe make this a constant like MIN_FAVICON_SIZE
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fix #3327. Generalize the icons so that it's just a rich icon instead of a screenshot